Skip to content

Conversation

krzksz
Copy link
Contributor

@krzksz krzksz commented Oct 28, 2019

Description (*)

This issue fixes the case where form_key field was being added to POST forms that had external (not belonging to shop's base URL) action URL.

Fixed Issues (if relevant)

  1. form_key parameter gets added to all forms #23382: form_key parameter gets added to all forms

Manual testing scenarios (*)

  1. Prepare a static block with following text content (with editor disabled):
<form action="https://google.com" method="POST"><input type="submit" value="Submit test form"></form>
  1. Add above static block to any CMS page.
  2. Go to the CMS page, open developer tools under Network tab with Preserve log checkbox checked.
  3. Click Submit test form button and verify that no form_key field was added to request parameters.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@krzksz krzksz requested a review from DrewML as a code owner October 28, 2019 20:56
@m2-assistant
Copy link

m2-assistant bot commented Oct 28, 2019

Hi @krzksz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@krzksz
Copy link
Contributor Author

krzksz commented Oct 28, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @krzksz. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, here is your new Magento instance.
Admin access: https://pr-25336.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6199 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Golf
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Nov 4, 2019

Hi @krzksz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants