-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Prevent adding form keys to forms with external action URLs #25336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @krzksz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @krzksz. Thank you for your request. I'm working on Magento instance for you |
Hi @krzksz, here is your new Magento instance. |
Hi @VladimirZaets, thank you for the review. |
✔️ QA Passed |
@magento run all tests |
Hi @krzksz, thank you for your contribution! |
Description (*)
This issue fixes the case where
form_key
field was being added to POST forms that had external (not belonging to shop's base URL) action URL.Fixed Issues (if relevant)
Manual testing scenarios (*)
Network
tab withPreserve log
checkbox checked.Submit test form
button and verify that noform_key
field was added to request parameters.Contribution checklist (*)