-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated theme preview images #25424
Updated theme preview images #25424
Conversation
Hi @drpayyne. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @drpayyne. Thank you for your request. I'm working on Magento instance for you |
Hi @drpayyne, here is your new Magento instance. |
@magento give me test instance |
Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you |
Hi @dmytro-ch, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @drpayyne,
I guess there is no need to add the preview images with high resolution. Magento still renders them in 800x800px. Thus it should be the most suitable size for preview images.
Could you please cut the images to be square and reduce the resolution to 800x800px?
Please, also squash all commits into a single commit in order to clean up history, after the changes are done.
Thank you!
a445a30
to
7690904
Compare
@dmytro-ch thank you. I have fixed it! |
Hi @dmytro-ch, thank you for the review. |
Hello @drpayyne. Thanks for contribution. Do You think it's a good idea to have "Test Category" on Theme's preview? |
@magento give me 2.3-develop instance |
Hi @drpayyne. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @drpayyne, here is your Magento instance. |
Having seen Your reaction @drpayyne I'm sorry if I put something not quite correctly in my previous comment. I just meant I had tested the instance with Your PR and there was that image preview. And so did You have an intention to leave there that Test Category? |
@engcom-Bravo oh no no, I was just disappointed that I left it there by mistake. Hence my reaction. Sorry that wasn't clear. Will push the fix soon. Thank you! |
@engcom-Bravo, fixed it. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @drpayyne, could you please squash the commits again to clean up history?
Thank you!
82655e6
to
ccef667
Compare
@dmytro-ch fixed, thanks! |
Hi @dmytro-ch, thank you for the review. |
✔️ QA Passed. |
Hi @drpayyne, thank you for your contribution! |
Description
Updated the theme preview images. Current theme preview image is from when Magneto was owned by eBay and has outdated logos and styles. Updated for
Magento/luma
andMagento/blank
with same page screenshot for consistency.Manual testing scenarios
Magento/blank
Magento/luma
Contribution checklist