Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated theme preview images #25424

Merged

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Nov 1, 2019

Description

Updated the theme preview images. Current theme preview image is from when Magneto was owned by eBay and has outdated logos and styles. Updated for Magento/luma and Magento/blank with same page screenshot for consistency.

Manual testing scenarios

  1. Navigate to Admin -> Content -> Design -> Themes
  2. View Magento/blank
  3. Click Theme Preview Image
  4. View Magento/luma
  5. Click Theme Preview Image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 1, 2019

Hi @drpayyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 1, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne, here is your new Magento instance.
Admin access: https://pr-25424.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch dmytro-ch self-assigned this Nov 1, 2019
@dmytro-ch
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-25424.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @drpayyne,
I guess there is no need to add the preview images with high resolution. Magento still renders them in 800x800px. Thus it should be the most suitable size for preview images.
Could you please cut the images to be square and reduce the resolution to 800x800px?
Please, also squash all commits into a single commit in order to clean up history, after the changes are done.

Thank you!

@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 2, 2019

@dmytro-ch thank you. I have fixed it!

@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6238 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

Hello @drpayyne. Thanks for contribution. Do You think it's a good idea to have "Test Category" on Theme's preview?
preview
(It concerns Luma as well).

@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 6, 2019

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @drpayyne, here is your Magento instance.
Admin access: https://i-25424-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Bravo
Copy link
Contributor

Having seen Your reaction @drpayyne I'm sorry if I put something not quite correctly in my previous comment. I just meant I had tested the instance with Your PR and there was that image preview. And so did You have an intention to leave there that Test Category?

@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 6, 2019

@engcom-Bravo oh no no, I was just disappointed that I left it there by mistake. Hence my reaction. Sorry that wasn't clear. Will push the fix soon. Thank you!

@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 6, 2019

@engcom-Bravo, fixed it. Thank you!

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drpayyne, could you please squash the commits again to clean up history?
Thank you!

@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 7, 2019

@dmytro-ch fixed, thanks!

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6238 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed.

@m2-assistant
Copy link

m2-assistant bot commented Nov 14, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: EY partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants