#25529: Fixed the wrong condition to output "Shipping Method Title" #25530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Magento/Checkout/view/frontend/web/js/view/summary/shipping.js" - added additional checking of shippingMethod type - need to be an array - fixed condition to output "shipping method title"
|
Hi @andrewbess. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
VladimirZaets
added
the
Auto-Tests: Not Required
VladimirZaets
approved these changes
Nov 8, 2019
magento-engcom-team
added
Partner: Atwix
"Magento/Checkout/view/frontend/web/js/view/summary/shipping.js" - fixed condition for shippingMethod
ghost
added
Progress: testing in progress
and removed
Progress: ready for testing
labels
|
Hi @VladimirZaets, Could you review the latest commit? |
VladimirZaets
approved these changes
Nov 11, 2019
|
Hi @VladimirZaets, thank you for the review. |
ghost
added
Progress: testing in progress
and removed
Progress: ready for testing
labels
|
✔️ QA Passed |
ghost
added
Progress: extended testing
and removed
Progress: testing in progress
labels
|
Hi @andrewbess, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The wrong condition to output "shipping method title" in Magento_Checkout/js/view/summary/shipping
return shippingMethod ?shippingMethod['carrier_title'] + shippingMethodTitle :shippingMethod['carrier_title'];What can happen if shippingMethod will not be an array?
Fixed Issues (if relevant)
Manual testing scenarios (*)
quote.shippingMethod('test')beforeshippingMethod = quote.shippingMethod();Questions or comments
Contribution checklist (*)