-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add right arrow to show some items have children #25624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add right arrow to show some items have children #25624
Conversation
Hi @fredden. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @fredden. Thank you for your collaboration. Using MFTF it's possible to assert that some element has a particular class. But in case of the |
Hey @fredden, can you take a look at failing static tests? |
Hi @krzksz, thank you for the review.
|
I'm marking tests for this as not required because this is purely visual improvement. |
Hi @rogyar, thank you for the review. |
Hi @fredden Problem: "Unsubscribe from Newsletter" has a right-facing arrow but doesn't have child options and with "Assign a Customer Group" all the way around Manual testing scenario:
@fredden Could you take a look? Thanks! |
Thanks for finding this bug. I think I've fixed it now. Please can you test again? |
Hi @krzksz, thank you for the review. |
✔️ QA Passed |
Hi @fredden, thank you for your contribution! |
Description (*)
This pull request adds a right-facing arrow to the drop-down options where an item has child options. Without this, it is not clear that clicking on (for example) 'Change status' has a very different next step than 'Update attributes' in the 'Actions' menu of the admin grid for products.
Fixed Issues (if relevant)
No known open issues for this.
Manual testing scenarios (*)
Questions or comments
I do not know if a unit test is required for
.less
changes. Please advise how I can do this should it be required.Contribution checklist (*)