Skip to content

Add right arrow to show some items have children #25624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

fredden
Copy link
Member

@fredden fredden commented Nov 16, 2019

Description (*)

This pull request adds a right-facing arrow to the drop-down options where an item has child options. Without this, it is not clear that clicking on (for example) 'Change status' has a very different next step than 'Update attributes' in the 'Actions' menu of the admin grid for products.

Screenshot_2019-11-16_14-55-06

Fixed Issues (if relevant)

No known open issues for this.

Manual testing scenarios (*)

  1. Log into admin
  2. Navigate to Product grid
  3. Open the 'action' menu
  4. Observe difference between 'Change status' and 'Update attributes' options.

Questions or comments

I do not know if a unit test is required for .less changes. Please advise how I can do this should it be required.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 16, 2019

Hi @fredden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar
Copy link
Contributor

rogyar commented Nov 16, 2019

Hi @fredden. Thank you for your collaboration. Using MFTF it's possible to assert that some element has a particular class. But in case of the ::after pseudo-class, I'm not sure there's a straightforward way.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:12
@krzksz
Copy link
Contributor

krzksz commented Dec 9, 2019

Hey @fredden, can you take a look at failing static tests?

@ghost ghost assigned krzksz Dec 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6435 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@fredden thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@krzksz krzksz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 10, 2019
@krzksz
Copy link
Contributor

krzksz commented Dec 10, 2019

I'm marking tests for this as not required because this is purely visual improvement.

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6435 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

Hi @fredden
During testing, we faced the issue.

Problem: "Unsubscribe from Newsletter" has a right-facing arrow but doesn't have child options and with "Assign a Customer Group" all the way around

Manual testing scenario:

  1. Log in to Admin;
  2. Go to Customers->All Customers;
  3. Open the 'action' menu;

Actual Result:
after2

@fredden Could you take a look?

Thanks!

@fredden
Copy link
Member Author

fredden commented Dec 12, 2019

Thanks for finding this bug. I think I've fixed it now. Please can you test again?

@engcom-Alfa engcom-Alfa requested review from krzksz and rogyar December 13, 2019 08:49
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6435 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Dec 16, 2019

Hi @fredden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@fredden fredden deleted the admin-action-parents branch December 16, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Fisheye partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants