Skip to content

Resolve Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google Chrome issue25647 #25648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2019
Merged

Resolve Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google Chrome issue25647 #25648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34998b6
Resolve Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google…
edenduong Nov 23, 2019
20fd591
Resolve Wrong Css at "Minimum Qty Allowed in Shopping Cart" on Google…
edenduong Nov 23, 2019
0a4393c
Fix static test
edenduong Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/CatalogInventory/Block/Adminhtml/Form/Field/Minsaleqty.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ protected function _getGroupRenderer()
'',
['data' => ['is_render_to_js_template' => true]]
);
$this->_groupRenderer->setClass('customer_group_select');
$this->_groupRenderer->setClass('customer_group_select admin__control-select');
}
return $this->_groupRenderer;
}
Expand All @@ -57,7 +57,7 @@ protected function _prepareToRender()
'min_sale_qty',
[
'label' => __('Minimum Qty'),
'class' => 'required-entry validate-number validate-greater-than-zero'
'class' => 'required-entry validate-number validate-greater-than-zero admin__control-text'
]
);
$this->_addAfter = false;
Expand Down
5 changes: 3 additions & 2 deletions ...ation/testsuite/Magento/CatalogInventory/Block/Adminhtml/Form/Field/CustomergroupTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@ protected function setUp()

public function testToHtml()
{
$this->_block->setClass('customer_group_select');
$this->_block->setClass('customer_group_select admin__control-select');
$this->_block->setId('123');
$this->_block->setTitle('Customer Group');
$this->_block->setInputName('groups[item_options]');
$expectedResult = '<select name="groups[item_options]" id="123" class="customer_group_select" '
$expectedResult = '<select name="groups[item_options]" id="123" '
. 'class="customer_group_select admin__control-select" '
. 'title="Customer Group" ><option value="32000" >ALL GROUPS</option><option value="0" >NOT LOGGED IN'
. '</option><option value="1" >General</option><option value="2" >Wholesale</option><option value="3" >'
. 'Retailer</option></select>';
Expand Down