Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mass action to invalidate indexes via admin #25860

Merged

Conversation

fredden
Copy link
Member

@fredden fredden commented Nov 30, 2019

Description (*)

This pull request adds the ability for an administrator to mark indexes as invalid via the admin. The indexes will then be run by the normal minutely cron.

Fixed Issues (if relevant)

I am not aware of any open issues regarding this change.

Manual testing scenarios (*)

  1. Browse to admin -> System -> Tools -> Index Management
  2. Select index tickbox
  3. Use mass-action drop-down to select 'invalidate index'
  4. Click 'submit'
  5. Observe index is now marked as invalid

Questions or comments

I have used the existing permission "Change indexer mode", but can move this to its own permission category if desired.

I copied the 'masschangelog' controller & test to make this action.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 30, 2019

Hi @fredden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:05
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now changes looks good, please fix tests issues

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Award: advanced labels Dec 17, 2019
@ghost ghost removed the Progress: needs update label Dec 17, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf
Copy link
Contributor

@magento run all tests

@slavvka
Copy link
Member

slavvka commented Jan 30, 2020

The failure of Sanity check is a known issue. https://jira.corp.magento.com/browse/MTS-852

@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2020

Hi @fredden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@fredden fredden deleted the admin-indexer-massinvalidte branch February 9, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants