Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ability to save configuration in field without label #25985

Conversation

AndreyChorniy
Copy link
Contributor

@AndreyChorniy AndreyChorniy commented Dec 11, 2019

Description (*)

This PR add the ability to save the configuration in the field without a label.

Fixed Issues (if relevant)

  1. system.xml file validation issue #23899: system.xml file validation issue

Manual testing scenarios (*)

  1. In system.xml create field without a label:
`<group id="test_group" translate="label" type="text" sortOrder="90" showInDefault="1" showInWebsite="1" showInStore="1">
                <field id="test_field" translate="label comment" type="text" sortOrder="10" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
                    <comment>Use {{name}} as Product Name placeholder</comment>
                </field>
</group>`
  1. Go to admin panel System -> Configuration -> {path_to_your_new_field}
  2. Fill this field
  3. Save configuration

Questions or comments

This fix deletes part of if expression. In my opinion, we don't need to disallow save fields without labels.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 11, 2019

Hi @AndreyChorniy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6460 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Charlie
Copy link
Contributor

Hello @AndreyChorniy
Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.
Thanks!

@engcom-Charlie engcom-Charlie added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Dec 13, 2019
@engcom-Golf engcom-Golf self-assigned this Jan 6, 2020
@engcom-Golf
Copy link
Contributor

I will take care of test coverage

@engcom-Golf engcom-Golf added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jan 6, 2020
@engcom-Golf
Copy link
Contributor

Hi @aleron75 all changes covered by unit test could you please review ?

@aleron75
Copy link
Contributor

aleron75 commented Jan 7, 2020

Hello @AndreyChorniy, can you please check the failing unit test?
Thanks

@engcom-Golf
Copy link
Contributor

@aleron75 test failed because i changed mock file, will fix them tomorrow's, and static test.

@Nazar65 Nazar65 force-pushed the fix-23899-system-xml-validation branch from fb97c83 to 63d43ed Compare January 7, 2020 19:57
@Nazar65 Nazar65 force-pushed the fix-23899-system-xml-validation branch 2 times, most recently from dd78e3a to f30a06a Compare January 7, 2020 20:25
@engcom-Golf
Copy link
Contributor

@aleron75 all done ✔️

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6460 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2020

Hi @AndreyChorniy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Config Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants