Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating wee -> weee in Magento_Weee README #25995

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

MellenIO
Copy link
Contributor

as per magento/devdocs#5911

Description (*)

There is a typo in the README for Magento_Weee. I originally edited this in devdocs but was referred back to the README here to edit it.

Fixed Issues (if relevant)

N/A - this was spotted in devdocs

Manual testing scenarios (*)

N/A

Questions or comments

This is just a small editorial change, so not sure what kind of process this needs to go through compared to a code change (or what branch it needs to go in to either)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 11, 2019

Hi @MellenIO. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned okorshenko Dec 11, 2019
@okorshenko okorshenko added Cleanup Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Weee labels Dec 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, thank you for the review.
ENGCOM-6450 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Dec 12, 2019

Hi @MellenIO, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@MellenIO MellenIO deleted the MellenIO-patch-1 branch December 12, 2019 13:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Weee Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants