[Downloadable] Cover the Observer SetHasDownloadableProductsObserver by Unit Test

[edenduong]

Description (*)

Cover the Observer SetHasDownloadableProductsObserver by Unit Test

Session has downloadable products

Session has no downloadable product

• Order has once item is downloadable product
• Order has all items are simple product

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

vendor/bin/phpunit app/code/Magento/Downloadable/Test/Unit/Observer/SetHasDownloadableProductsObserverTest.php

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @kalpmehta, thank you for the review.
ENGCOM-6479 has been created to process this Pull Request

[engcom-Charlie]

✔️ QA Passed

[lbajsarowicz]

I see that you always test with the same value for productType and realProductType`.
In that specific case, it's against YAGNI :-)

Removing the redundant argument, you'll also get side effect of cleaner DataProvider method (oneliners)

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.