Performance: Getting rid of array_merge in loop

[lbajsarowicz]

Description (*)

Work In Progress Related with removing foreach() { $x = array_merge($x, $this->x()); }

Fixed Issues (if relevant)

Nope

Manual testing scenarios (*)

Nope

Questions or comments

Nope.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6595 has been created to process this Pull Request

[engcom-Golf]

SVC checker failure is not valid as method return type was not changed

[lbajsarowicz]

@engcom-Golf I rolled back change of return type to have 100% green.

[ihor-sviziev]

@lbajsarowicz thank you for reverting changes that require approval. Could you also resolve merge conflict that just appeared?

[lbajsarowicz]

@magento run all tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6595 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.