Skip to content

Conversation

atwixfirster
Copy link
Contributor

Description (*)

PR adds a unit test which cover \Magento\AdminNotification\Observer\PredispatchAdminActionControllerObserver class.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Thank you!

@m2-assistant
Copy link

m2-assistant bot commented Jan 15, 2020

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 15, 2020
@rogyar rogyar self-assigned this Jan 15, 2020
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Jan 15, 2020
@ghost ghost assigned dmytro-ch Jan 15, 2020
@atwixfirster atwixfirster force-pushed the unittest-PredispatchAdminActionControllerObserver branch 2 times, most recently from b6485cd to 5a06bb9 Compare January 15, 2020 16:50
@atwixfirster atwixfirster force-pushed the unittest-PredispatchAdminActionControllerObserver branch from 5a06bb9 to 936f38f Compare January 15, 2020 20:21
@atwixfirster atwixfirster force-pushed the unittest-PredispatchAdminActionControllerObserver branch from 936f38f to 504bfe5 Compare January 16, 2020 21:07
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6626 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@ghost ghost added the Progress: accept label Jan 17, 2020
magento-engcom-team pushed a commit that referenced this pull request Jan 28, 2020
…ion\Observer\PredispatchAdminActionControllerObserver #26402
@magento-engcom-team magento-engcom-team merged commit 504bfe5 into magento:2.4-develop Jan 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: AdminNotification Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants