Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test for Magento\Sitemap\Model\Config\Backend\Priority #26430

Merged
merged 3 commits into from
Feb 9, 2020
Merged

Unit Test for Magento\Sitemap\Model\Config\Backend\Priority #26430

merged 3 commits into from
Feb 9, 2020

Conversation

karyna-tsymbal-atwix
Copy link
Contributor

Description (*)

Covers Magento\Sitemap\Model\Config\Backend\Priority class with a unit test.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 17, 2020
lbajsarowicz
lbajsarowicz suggested changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little change to test name

app/code/Magento/Sitemap/Test/Unit/Model/Config/Backend/PriorityTest.php Outdated Show resolved Hide resolved
@ghost ghost assigned lbajsarowicz Jan 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6629 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Jan 17, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Golf engcom-Golf self-assigned this Jan 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6629 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Golf
Copy link
Contributor

failed Functional Tests B2B Not related to the changes in this PR

@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 21, 2020
magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2020
@slavvka
ENGCOM-6629: Unit Test for Magento\Sitemap\Model\Config\Backend\Prior…
9a91bee 
…ity #26430
@magento-engcom-team magento-engcom-team merged commit 1df8216 into magento:2.4-develop Feb 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2020

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@karyna-tsymbal-atwix karyna-tsymbal-atwix deleted the unit-test-magento-sitemap-model-priority branch August 6, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Delta engcom-Delta

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: Sitemap Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@karyna-tsymbal-atwix @magento-engcom-team @engcom-Delta @engcom-Golf @lbajsarowicz @VladimirZaets @Nazar65