Skip to content

Conversation

schurter-wallee
Copy link

The registerRefundNotification(...) method tries to register a credit memo, but the register() method does not longer exist in the \Magento\Sales\Model\Order\Creditmemo class.

@Vinai
Copy link
Contributor

Vinai commented Dec 15, 2015

Thank you for the PR! We are currently waiting for the travis builds to work again, which should happen in a few days. Once that is running and the tests are green we can continue to process your contribution. Until then, can you please sign the contributor license agreement?

@KrystynaKabannyk
Copy link

hello @schurter-cw, can you please update code of the PR and cover it by Travis tests?

@rikterbeek
Copy link

Hi @Vinai

Could you please accept the pull request from @schurter-cw this will solve issues for us as well.

It is difficult to create a credit memo programmatically because the prepareCreditMemo is a protected function what is the best method to use ?

Regards,
Rik

@rikterbeek
Copy link

@NadiyaS Could you look at my question above ?

@stevenvdp
Copy link
Contributor

The travis build is still disabled? Our build server gives this message:

Magento\Sales\Test\Unit\Model\Order\PaymentTest::testRegisterRefundNotification
Expectation failed for method name is equal to <string:register> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

@schurter-cw perhaps you should also update the test in your PR.

@NadiyaS
Copy link
Contributor

NadiyaS commented May 10, 2016

Hi @schurter-cw, @rikterbeek
thank you for contribution and we are sorry for delay.
Internal ticket for processing your PR is MAGETWO-47123.

@NadiyaS NadiyaS added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 10, 2016
@alena-marchenko
Copy link

The fix has been delivered to develop branch.
Thank you for contribution!

magento-engcom-team pushed a commit that referenced this pull request Jun 6, 2018
[TSG] Upporting for 2.3 (pr21) (2.3.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants