Skip to content

Improve exception message #26586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 26, 2020
Merged

Improve exception message #26586

merged 7 commits into from
Feb 26, 2020

Conversation

orozcodiaz
Copy link
Contributor

This fix improves the exception message in class \Magento\Checkout\Model\ShippingInformationManagement

@m2-assistant
Copy link

m2-assistant bot commented Jan 29, 2020

Hi @oroskodias. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 29, 2020
@orozcodiaz orozcodiaz removed Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner labels Jan 29, 2020
kandy
kandy reviewed Jan 29, 2020
View reviewed changes
ihor-sviziev
ihor-sviziev requested changes Jan 30, 2020
View reviewed changes
@ghost ghost assigned ihor-sviziev Jan 30, 2020
lbajsarowicz
lbajsarowicz suggested changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more information about logging the exceptions, after reading @ihor-sviziev recommendations.

@ghost ghost assigned lbajsarowicz Jan 30, 2020
@ihor-sviziev
Copy link
Contributor

Hi @oroskodias,
Are you going to finalize your PR?

@orozcodiaz
Copy link
Contributor Author

@ihor-sviziev I'm unable to proceed with it currently

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Feb 17, 2020
@engcom-Charlie engcom-Charlie self-assigned this Feb 19, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Feb 19, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

lbajsarowicz
lbajsarowicz suggested changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look into comments.

lbajsarowicz
lbajsarowicz suggested changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, maybe I wasn't clear.
You don't need doc block for const at all 👍

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6941 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6941 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Feb 25, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

magento-engcom-team pushed a commit that referenced this pull request Feb 26, 2020
@slavvka
ENGCOM-6941: Improve exception message #26586
4f5f26c
@magento-engcom-team magento-engcom-team merged commit e6d63e7 into magento:2.4-develop Feb 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @oroskodias, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandy kandy kandy left review comments

@engcom-Charlie engcom-Charlie engcom-Charlie left review comments

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Checkout Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@orozcodiaz @ihor-sviziev @engcom-Charlie @magento-engcom-team @engcom-Alfa @kandy @lbajsarowicz