Skip to content

Comment add in translate. #26674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 13, 2020

Conversation

pratikhmehta
Copy link
Contributor

@pratikhmehta pratikhmehta commented Feb 3, 2020

Description (*)

I did add comment in translate attribute of <Comment>.

@m2-assistant
Copy link

m2-assistant bot commented Feb 3, 2020

Hi @pratikhmehta. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pratikhmehta, please add these values to the translation file. Thanks.

@ghost ghost assigned lenaorobei Feb 6, 2020
@pratikhmehta
Copy link
Contributor Author

Hi @pratikhmehta, please add these values to the translation file. Thanks.

Yes, let me add it and again pull the request.

@lenaorobei
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@lenaorobei lenaorobei added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Feb 11, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6854 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Charlie
Copy link
Contributor

Failed functional test not related to the changes in this PR test fails in 2.4-develop with MSI modules.
image

@magento-engcom-team magento-engcom-team merged commit f1c1ec3 into magento:2.4-develop Feb 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @pratikhmehta, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants