{ASI} : SortBy component added

[konarshankar07]

Description (*)

Sortby component is developed for Adobe Stock Integration project

Related Pull Requests

magento/adobe-stock-integration#938

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[konarshankar07]

Hello @sivaschenko ,
Where we need to add the css code for this component?

[sivaschenko]

@konarshankar07 yes, please add it to the theme

[konarshankar07]

@konarshankar07 yes, please add it to the theme

I mean which file _data-grid.less or _masonry-grid.less file?

[sivaschenko]

@konarshankar07 _masonry-grid.less, thanks

[konarshankar07]

@magento run all tests

[konarshankar07]

Hello @sivaschenko ,
As I checked further, The CSS changes are not part of the magento repo so please start the code review and also help me to fix the B2B static test
Thanks

[sivaschenko]

Hi @konarshankar07 do you mean the component is properly styled even if it's used without adobe stock integration like in this example: https://github.com/sivaschenko/masonry-grid-example ?

[sivaschenko]

@magento run Static Tests

[konarshankar07]

Hello @sivaschenko ...
Sorry for the confusion regarding styling. Somehow I missed the styling for the sortBy component so now I've added the styling. Here is the screenshot

Thanks

[sivaschenko]

Thanks for the updates @konarshankar07 , can you please fix the static tests?

Pull Request state was updated. Re-review required.

[konarshankar07]

Hello @sivaschenko and @engcom-Bravo ....
I have fixed the sorting direction. Please review and test now
Thanks

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-7210 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

[chalov-anton]

@konarshankar07
Can you please add Sorting by Uploaded date?
Thank you

[m2-assistant]

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.