In System/Export controlers use MessageManager instead of throwing exceptions

[pmarki]

Description (*)

Currently when you try to download or delete a file from Magento admin in System/Export section if the file is corrupted or was already deleted both controllers will throw exceptions that won't be caught. This will result in internal server error. I have refactor ImportExport\Controller\Adminhtml\Export\File\Delete and ImportExport\Controller\Adminhtml\Export\File\Download controllers. They will use messageManager instead of throwing errors. This means admin user will see proper success/error messages as in other admin areas.

Related Pull Requests

NA

Fixed Issues (if relevant)

NA

Manual testing scenarios (*)

1. Go to Magento admin and navigate to System/Export
2. Export some entities
3. Keep the tab open and in a new tab go to the same page and delete one file
4. Try to delete/download the same file in the first tab (without refreshing before)
5. User friendly message will be visible

Testing can be done with SSH access to file system: File to download\delete can be made corrupted, ready only, no access to apache user, new folder can be created in var/export, etc.

Questions or comments

The section with files to download shouldn't list folders. I'll try to fix this in a separate PR.

Contribution checklist (*)

• [x ] Pull request has a meaningful description of its purpose
• [ x] All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @pmarki. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[eduard13]

Hi @pmarki, thank you for your contribution.
Could you please review the comments below related to the backslash and answer the question?
Also, please provide the translations for new texts into i81n/en_US.csv.

Additionally, based on Magento Definition of Done all the changes have to be to covered by automated tests.
Thank you.

[eduard13]

Hi @pmarki, thank you for the test coverage, here are couple of suggestions, could you please adjust the tests based on them?
Please do the same for the other test.
Please check the failing static tests as well.

Thank you.

[eduard13]

Hi @pmarki, thank you for the test adjustments, could you please check the failing Static Tests and fix them?
Thanks.

[pmarki]

hi @eduard13 Static tests fixed. I checked other failed tests and looks like it is not related to my changes. Let me know if anything else can be improved and thank you for your patience, I'm doing PR for Magento first time, plenty of things to check :)

[eduard13]

@magento run all tests

[eduard13]

Hi @pmarki, awesome 🎉. You're welcome, and thank you for all the fixes. The failing functional tests indeed aren't related with the existing changes, but let's wait them to finish running.

[eduard13]

The failing tests aren't related to these changes.

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-7083 has been created to process this Pull Request

[magento-engcom-team]

@pmarki thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Delta]

✔️ QA passed

[engcom-Golf]

@magento run all tests

[engcom-Golf]

Failed functional tests not related to the changes in this PR

[m2-assistant]

Hi @pmarki, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.