[Theme] Covered Unit Test for \Magento\Theme\Controller\Result\JsFooterPlugin

[srsathish92]

Description (*)

[Theme] Covered Unit Test for \Magento\Theme\Controller\Result\JsFooterPlugin

Manual testing scenarios (*)

vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/Theme/Test/Unit/Controller/Result/JsFooterPluginTest.php

Questions or comments

If any please let me know your feedback

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-6867 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[lbajsarowicz]

Could you cover that case, too?

[srsathish92]

Could you cover that case, too?

@lbajsarowicz yes, I have covered & updated, please review now.

[lbajsarowicz]

Please add keys that description for DataProvider.
Then we need to check if everything works as expected.

[lbajsarowicz]

You can replace this with:

'empty_array' => ['content' => []],
'null' => ['content' => NULL]

As a result - when one of them fail - You'll know on which data set it failed (key of dataProvider is added to error message (Test failed with: X))

[srsathish92]

@lbajsarowicz Thanks for the feedback, I have updated the keys.

[lbajsarowicz]

Tests passed, thanks for your contribution.

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6867 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

[engcom-Charlie]

Failed functional test not related to the changes in this PR test fails in 2.4-develop with MSI modules.

[m2-assistant]

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.