Skip to content

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Feb 12, 2020

Description (*)

PR adds API-functional test cases to cover the next exceptions of mergeCarts mutation:

Related Pull Requests

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Thank you!

@m2-assistant
Copy link

m2-assistant bot commented Feb 12, 2020

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 12, 2020
@ghost ghost assigned lenaorobei Feb 12, 2020
@lenaorobei lenaorobei added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Feb 12, 2020
@engcom-Bravo engcom-Bravo self-assigned this Feb 12, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6870 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Tests are added and pass
MergeCartTest

@engcom-Golf engcom-Golf self-assigned this Feb 13, 2020
magento-engcom-team pushed a commit that referenced this pull request Feb 22, 2020
@magento-engcom-team magento-engcom-team merged commit fb328b9 into magento:2.4-develop Feb 22, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 22, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants