Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/26843: Fix es_US Spanish (United States ) Locale is not support… #26857

Merged
merged 3 commits into from
Feb 20, 2020

Conversation

vincentle89
Copy link
Contributor

@vincentle89 vincentle89 commented Feb 13, 2020

…ed in Magento 2.3.4 #26843

Fix missing code es_US in the list of available locales

Description (*)

Fix missing code in the list of available locales

Fixed Issues (if relevant)

  1. es_US Spanish (United States ) Locale is not supported in Magento 2.3.4 #26843: es_US Spanish (United States ) Locale is not supported in Magento 2.3.4

Manual testing scenarios (*)

  1. Create a store view and set locale as "es_US"
  2. Run command: php bin/magento setup:static-content:deploy -f --theme="Magento/blank" es_US

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @vincent-le89. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@vincentle89
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @vincent-le89. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @vincent-le89, here is your new Magento instance.
Admin access: https://pr-26857.instances.magento-community.engineering/admin_826a
Login: 88fbb848 Password: edcc7125083d
Instance will be terminated in up to 3 hours.

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 14, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing functional tests are not related to changes from this PR

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6899 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@vincent-le89 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@magento-engcom-team magento-engcom-team merged commit 13f5919 into magento:2.4-develop Feb 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 20, 2020

Hi @vincent-le89, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

es_US Spanish (United States ) Locale is not supported in Magento 2.3.4
5 participants