Skip to content

magento/magento2#: GraphQl. Remove a redundant logic in “SetShippingMethodsOnCart” mutation resolver #27349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2020
Merged

magento/magento2#: GraphQl. Remove a redundant logic in “SetShippingMethodsOnCart” mutation resolver #27349

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
baa17d7
magento/magento2#: GraphQl. Remove a redundant logic in “SetShippingM…
atwixfirster Mar 19, 2020
e5721c1
Merge branch '2.4-develop' into graphql-SetShippingMethodsOnCart-remo…
atwixfirster Mar 25, 2020
bc5cd19
Merge branch '2.4-develop' into graphql-SetShippingMethodsOnCart-remo…
atwixfirster Apr 30, 2020
6ad7552
Merge branch '2.4-develop' into graphql-SetShippingMethodsOnCart-remo…
avattam06 Jun 16, 2020
58e7441
Merge branch '2.4-develop' into graphql-SetShippingMethodsOnCart-remo…
avattam06 Jun 17, 2020
1f5efdf
Merge branch '2.4-develop' into graphql-SetShippingMethodsOnCart-remo…
avattam06 Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/QuoteGraphQl/Model/Cart/SetShippingMethodsOnCart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ public function execute(ContextInterface $context, CartInterface $cart, array $s
}
$shippingMethodInput = current($shippingMethodsInput);

if (!isset($shippingMethodInput['carrier_code']) || empty($shippingMethodInput['carrier_code'])) {
if (empty($shippingMethodInput['carrier_code'])) {
throw new GraphQlInputException(__('Required parameter "carrier_code" is missing.'));
}
$carrierCode = $shippingMethodInput['carrier_code'];

if (!isset($shippingMethodInput['method_code']) || empty($shippingMethodInput['method_code'])) {
if (empty($shippingMethodInput['method_code'])) {
throw new GraphQlInputException(__('Required parameter "method_code" is missing.'));
}
$methodCode = $shippingMethodInput['method_code'];
Expand Down