-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Implement ActionInterface for /search/term/popular #27462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ActionInterface for /search/term/popular #27462
Conversation
Hi @Bartlomiejsz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
app/code/Magento/Search/Test/Unit/Controller/Term/PopularTest.php
Outdated
Show resolved
Hide resolved
app/code/Magento/Search/Test/Unit/Controller/Term/PopularTest.php
Outdated
Show resolved
Hide resolved
@Bartlomiejsz usually for objects using |
@ihor-sviziev yes, it works for both. I modified it to |
Looks good. I'll review this PR after all tests will be finished |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have quite a lot functional tests failures, but seems like they are not related to changes from this PR.
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed |
Failed functional tests not related to the changes in this PR |
Hi @Bartlomiejsz, thank you for your contribution! |
Description (*)
This is a part of the process of introducing implementations of
ActionInterface
.Related Pull Requests
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
N/A
Questions or comments
Contribution checklist (*)