Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixed #26191] Need To Change Label In Totals Block in Order View Page #27516

Merged
merged 17 commits into from
Jul 16, 2020
Merged

[Fixed #26191] Need To Change Label In Totals Block in Order View Page #27516

merged 17 commits into from
Jul 16, 2020

Conversation

madhurajawat
Copy link

@madhurajawat madhurajawat commented Mar 31, 2020 •
edited by engcom-Echo
Loading

Description (*)

Need To Change Label In Totals Block in Order View Page # 26191

Related Pull Requests

Fixed Issues (if relevant)

  1. Need To Change Label In Totals Block in Order View Page #26191: Need To Change Label In Totals Block in Order View Page

Manual testing scenarios (*)

  1. Place Order with 5 Items.
  2. Create Invoice For 1st 3 Items.
  3. Cancel Order.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 31, 2020

Hi @madhu-ranosys. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@lbajsarowicz
Copy link
Contributor

Could you provide more descriptive title to your PR? For future reference, such as searching that is really helpful :-)

@madhurajawat madhurajawat changed the title fix-26191 [Fixed #26191] Need To Change Label In Totals Block in Order View Page Mar 31, 2020
@madhurajawat
Copy link
Author

Could you provide more descriptive title to your PR? For future reference, such as searching that is really helpful :-)

Sure, Updated PR title.

@gwharton
Copy link
Contributor

gwharton commented Apr 1, 2020

Total cancel is not great english. Should it be total canceled. Also translatable strings should be added to module i18n en_us.csv file.

@gwharton gwharton mentioned this pull request Apr 1, 2020
Closed
4 tasks
@madhurajawat
Copy link
Author

Total cancel is not great english. Should it be total canceled. Also translatable strings should be added to module i18n en_us.csv file.

Yes, We can update it with total canceled and translatable strings.

@madhurajawat
Copy link
Author

Total cancel is not great english. Should it be total canceled. Also translatable strings should be added to module i18n en_us.csv file.

@gwharton Submitted PR with the changes.

@madhurajawat madhurajawat requested a review from swnsma April 8, 2020 05:59
swnsma
swnsma requested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @madhu-ranosys !
Thank you for your contribution.
Could you please sign Adobe CLA? https://github.com/magento/magento2/pull/27516/checks?check_run_id=586465685
Thank you!

@ghost ghost assigned swnsma Apr 14, 2020
@madhurajawat
Copy link
Author

madhurajawat commented Apr 15, 2020 •
edited
Loading

Hi @madhu-ranosys !
Thank you for your contribution.
Could you please sign Adobe CLA? https://github.com/magento/magento2/pull/27516/checks?check_run_id=586465685
Thank you!

It's done.

@madhurajawat
Copy link
Author

madhurajawat commented Apr 16, 2020 •
edited
Loading

@swnsma Please help to verify.

@madhurajawat madhurajawat marked this pull request as draft April 20, 2020 07:15
@swnsma
Copy link
Contributor

swnsma commented Apr 20, 2020

Hi @madhurajawat,
I see that you have set this PR as a 'Draft'.
Please set is as 'ready for review' as soon as you will realize that this is ready for review.
Also, please check failed static tests.

@madhurajawat madhurajawat marked this pull request as ready for review April 20, 2020 17:19
@engcom-Echo
Copy link
Contributor

I will take care of test coverage

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo requested a review from swnsma July 1, 2020 11:31
@engcom-Delta engcom-Delta self-assigned this Jul 9, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked case from Manual testing scenarios
Before:
#27516Main

After:
#27516PR

@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 9, 2020
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 10, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jul 13, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Jul 16, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jul 16, 2020
@slavvka
ENGCOM-7770: [Fixed #26191] Need To Change Label In Totals Block in O…
78e9736 
…rder View Page #27516
@magento-engcom-team magento-engcom-team merged commit 9be4edd into magento:2.4-develop Jul 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2020

Hi @madhurajawat, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swnsma swnsma swnsma approved these changes

Assignees

@swnsma swnsma

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Award: bug fix Component: Sales help wanted Partner: Ranosys Technologies partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
9 participants
@madhurajawat @lbajsarowicz @gwharton @swnsma @VladimirZaets @engcom-Echo @engcom-Delta @slavvka @magento-engcom-team