Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant fieldset in sale rule form #27585

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Remove redundant fieldset in sale rule form #27585

merged 1 commit into from
Sep 25, 2020

Conversation

edenduong
Copy link
Contributor

@edenduong edenduong commented Apr 4, 2020 •
edited by sidolov
Loading

Description (*)

This PR remove redundant fieldset in sale rule form. "Currently Active". This field is used in Magento Commerce, not in open source.

image

Should be:

image

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/170

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to backend.
  2. Create New Cart Price Rule.

Check:

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Remove redundant fieldset in sale rule form #29599: Remove redundant fieldset in sale rule form

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 4, 2020
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
@sidolov
Copy link
Contributor

sidolov commented Aug 17, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 17, 2020
Closed
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Aug 27, 2020
@ghost ghost assigned sidolov Aug 27, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8090 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Sep 4, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 4, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Result:
❌ Before:
image

✔️ After:
image

@engcom-Delta
Copy link
Contributor

Note: Functional Tests B2B are failed

@engcom-Delta engcom-Delta moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 4, 2020
@engcom-Charlie engcom-Charlie self-assigned this Sep 4, 2020
@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Sep 7, 2020
@engcom-Charlie engcom-Charlie added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 24, 2020
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Sep 24, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 24, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 25, 2020
@sidolov
ENGCOM-8090: Remove redundant fieldset in sale rule form #27585
f36a155
@magento-engcom-team magento-engcom-team merged commit 589ae71 into magento:2.4-develop Sep 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 25, 2020

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: SalesRule Event: Global-Contribution-Day Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. tech-partners-contribution Technology Partner: Magestore
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Remove redundant fieldset in sale rule form
5 participants
@edenduong @sidolov @magento-engcom-team @engcom-Delta @engcom-Charlie