Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Use StorefrontOpenCartPageActionGroup to go to Checkout page #27846

Merged
merged 3 commits into from
Apr 18, 2020
Merged

[MFTF] Use StorefrontOpenCartPageActionGroup to go to Checkout page #27846

merged 3 commits into from
Apr 18, 2020

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR uses StorefrontOpenCartPageActionGroup to go to Checkout page and removes this part of code
<amOnPage url="{{CheckoutCartPage.url}}" stepKey="onPageShoppingCart"/>
<waitForPageLoad stepKey="waitForCartPageLoad"/>

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 13, 2020
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 13, 2020
@eduard13 eduard13 self-assigned this Apr 13, 2020
@lbajsarowicz
Copy link
Contributor

It's not hard requirements, but as I previously mentioned - could you change the naming to:
StorefrontCartPageOpenActionGroup ? This is because then you'll get hints on all the actions that can be performed on some specific area. For example: StorefrontCart| and then it shows all the actions one by another, not randomly mixed with StorefrontConfigurableProductAddToCartActionGroup :-)

@Usik2203
Copy link
Contributor Author

Hi @lbajsarowicz .
Thank you for remarking. I will try to choose names more carefully.

@lbajsarowicz
Copy link
Contributor

@Usik2203 I'm glad that you improve such annoying parts of MFTF.

lbajsarowicz
lbajsarowicz approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 14, 2020
@ghost ghost assigned lbajsarowicz Apr 14, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7408 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 16, 2020
@engcom-Alfa engcom-Alfa self-assigned this Apr 16, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 16, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 16, 2020
@engcom-Echo engcom-Echo self-assigned this Apr 16, 2020
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 18, 2020
@slavvka slavvka added this to the 2.4.0 milestone Apr 18, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 18, 2020
@slavvka
ENGCOM-7408: [MFTF] Use StorefrontOpenCartPageActionGroup to go to Ch…
9f99f88 
…eckout page #27846
@magento-engcom-team magento-engcom-team merged commit 9419754 into magento:2.4-develop Apr 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Apr 18, 2020
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@eduard13 eduard13

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Bundle Component: Catalog Component: CatalogInventory Component: CatalogRule Component: Checkout Component: ConfigurableProduct Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Usik2203 @lbajsarowicz @magento-engcom-team @engcom-Alfa @engcom-Echo @slavvka @eduard13