Configurable product not showing price on category and product page #…

[madhurajawat]

…28068

Configurable product not showing price on category and product page when all the associated products are out of stock.

Description (*)

Configurable product not showing price on category and product page when all the associated products are out of stock.

Related Pull Requests

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Configurable product not showing price on category and product page Configurable product not showing price on category and product page #28068

Manual testing scenarios (*)

1. Create a configurable product, all simple products are out of stock
2. Go to -> detail page of the configurable product
3. The product price does not show

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @madhurajawat. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered only manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s). <test-build(s)> is a comma-separated list of build names. Allowed build names are Database Compare, Functional Tests CE, Functional Tests EE, Functional Tests B2B, Integration Tests, Magento Health Index, Sample Data Tests CE, Sample Data Tests EE, Sample Data Tests B2B, Static Tests, Unit Tests, WebAPI Tests.

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[Serializator]

Magento\Catalog\Pricing\Render\FinalPriceBox extends from Magento\Framework\Pricing\Render\PriceBox (BasePriceBox).

If I'm not mistaken, with the above in the mind the parent class is actually called twice, once through parent::_toHtml and once through BasePriceBox::_toHtml, is there a reason for this and thus on purpose or not?

[Serializator]

I'd refactor everything related to $msrpPriceType into the try-catch in which $msrpPriceType is defined, this way the return logic ($this->wrapResult($result)) is not duplicated.

I can understand if this was done to prevent too much indentation by using an early return. In this case I'd argue that it might be better to refactor it into a separate method responsible for returning either the HTML for the MSRP price rendering or an empty string in case of the exception for example, minimising the overal indentation.

[pradeepkanaka]

Is this a valid fix?