[Integration] Refactoring some fixtures for cms module

[Usik2203]

Description (*)

This PR refactores some fixtures for CMS module

[m2-assistant]

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[Usik2203]

@magento run all tests

[ihor-sviziev]

Hi @Usik2203,
Please review the test failures and update your changes accordingly.

[Usik2203]

@magento run all tests

[Usik2203]

@magento run WebAPI Tests

[Usik2203]

I can't see errors in WebAPI Tests and Integration Tests related with my changes.
Seems they are just failed, but without error messages
Thanks

[ihor-sviziev]

@slavvka @lenaorobei @sdzhepa could you give some additional info why integration & web api tests are failing?

[lenaorobei]

@magento run all tests

[lenaorobei]

Updated branch and rerun builds. Will monitor logs.

[lenaorobei]

Integration failure is not related to this PR. We are investigating this issue, it appears for every run.

WebAPI build failure is caused by:

09:29:55 [WebAPI GRAPHQL-Tests-CE] ..........................PHP Fatal error:  Uncaught Exception: Exception occurred when running the "\/var\/www\/html\/dev\/tests\/integration\/testsuite\/Magento\/Cms\/_files\/pages.php" fixture: 
09:29:55 [WebAPI GRAPHQL-Tests-CE] Notice: Undefined variable: objectManager in /var/www/html/dev/tests/integration/testsuite/Magento/Cms/_files/pages.php:18. in /var/www/html/dev/tests/api-functional/framework/Magento/TestFramework/Annotation/ApiDataFixture.php:114

[Usik2203]

@magento run all tests

[ihor-sviziev]

Wow. So files from integration tests are used in web api tests? 🤦‍♂️

[lenaorobei]

Yes, they are used for both test types in order to avoid duplications.

[ihor-sviziev]

Yes, they are used for both test types in order to avoid duplications.

Got it, I believe it should be extracted to not specific test type folder, just to app/code/Magento/ModuleName/Test/_files/ what do you thing? At least that used by few test types

[lenaorobei]

@ihor-sviziev that sounds like a good idea but it might require huge effort to update framework and fix all tests.

[ihor-sviziev]

✅ approved! Failing integration tests not related to changes from this PR

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7613 has been created to process this Pull Request

[engcom-Alfa]

QA not applicable

[m2-assistant]

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.