Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed array creation to be in line with the class #28515

Merged
merged 4 commits into from
Jun 24, 2020

Conversation

litsher
Copy link
Contributor

@litsher litsher commented Jun 4, 2020

Make the array creation consistent throughout the class.
This is mostly just a convention fix.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Changed array creation to be in line with the class #28795: Changed array creation to be in line with the class

Make the array creation consistent throughout the class
@m2-assistant
Copy link

m2-assistant bot commented Jun 4, 2020

Hi @litsher. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@litsher
Copy link
Contributor Author

litsher commented Jun 4, 2020

@magento run all tests

@litsher litsher changed the title Changed array creation Changed array creation to be in line with the class Jun 4, 2020
@rogyar rogyar self-assigned this Jun 7, 2020
@rogyar
Copy link
Contributor

rogyar commented Jun 7, 2020

@magento run all tests

@rogyar
Copy link
Contributor

rogyar commented Jun 8, 2020

@magento run Integration Tests

@rogyar rogyar added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Jun 8, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jun 8, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7651 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@litsher thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@litsher
Copy link
Contributor Author

litsher commented Jun 10, 2020

@magento run all tests

@engcom-Alfa engcom-Alfa self-assigned this Jun 18, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jun 18, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Was tested Print invoice functionality and everything work as previously (expected).

Manual testing scenario:

  1. Create order with few products;
  2. Create an invoice;
  3. Go to Admin->Sales->Invoices;
  4. Select view link on created before invoice;
  5. Click on Print button;
  6. Open created pdf file

Actual Result: ✔️ Product names are displayed correctly

screenshot_67

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jun 18, 2020
@engcom-Charlie engcom-Charlie self-assigned this Jun 18, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jun 19, 2020
@magento-engcom-team magento-engcom-team merged commit f2b905c into magento:2.4-develop Jun 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2020

Hi @litsher, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jun 24, 2020
@litsher litsher deleted the patch-1 branch June 24, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Sales Progress: accept Release Line: 2.4
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

[Issue] Changed array creation to be in line with the class
5 participants