Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Use actionGroup go to CatalogRulePage #28999

Merged
merged 1 commit into from
Jul 23, 2020
Merged

[MFTF] Use actionGroup go to CatalogRulePage #28999

merged 1 commit into from
Jul 23, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Jul 6, 2020

This PR use AdminOpenCatalogPriceRulePageActionGroup to go to CatalogRulePage instead
<amOnPage stepKey="goToPriceRulePage" url="{{CatalogRulePage.url}}"/>

@m2-assistant
Copy link

m2-assistant bot commented Jul 6, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jul 6, 2020
@magento-engcom-team magento-engcom-team added Component: CatalogRule Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 6, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 6, 2020

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@rogyar rogyar self-assigned this Jul 6, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 6, 2020

@magento run Functional Tests EE

@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 6, 2020

Seems failed Functional EE test is not related with my changes.

@rogyar
Copy link
Contributor

rogyar commented Jul 6, 2020

Hi @Usik2203. You haven't touched this test. So most likely it's a temporary issue. Thank you

@rogyar rogyar added Cleanup Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jul 6, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jul 6, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7784 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 10, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 10, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 10, 2020
@engcom-Charlie engcom-Charlie self-assigned this Jul 10, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jul 10, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jul 21, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 23, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 23, 2020
@slavvka
ENGCOM-7784: [MFTF] Use actionGroup go to CatalogRulePage #28999
35a1b12
@magento-engcom-team magento-engcom-team merged commit df6bb34 into magento:2.4-develop Jul 23, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 23, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: CatalogRule Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Usik2203 @rogyar @magento-engcom-team @engcom-Alfa @engcom-Charlie @slavvka