-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable Product Links Validation Bug when int value is 0 #29001
Configurable Product Links Validation Bug when int value is 0 #29001
Conversation
Hi @engcom-Charlie. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @engcom-Charlie, could you please review the failing WebAPI Test?
Thank you for your contribution.
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Looks like the failing test isn't related with the current changes.
Hi @eduard13, thank you for the review. |
✔️ QA Passed Tested according to the steps, described in comment Manual testing scenario:
Before: ✖️ Exception thrown: Product with id "%1" does not contain required attribute "%2"." After: ✔️ Configurable Product was created with the linked simple product |
Hi @engcom-Charlie, thank you for your contribution! |
Description (*)
Fixed and covered by test
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
See #13210
Questions or comments
Contribution checklist (*)