Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Product Links Validation Bug when int value is 0 #29001

Merged
merged 2 commits into from
Jul 18, 2020

Conversation

engcom-Charlie
Copy link
Contributor

Description (*)

Fixed and covered by test

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Configurable Product Links Validation Bug when int value is 0 #13210

Manual testing scenarios (*)

See #13210

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 6, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@eduard13 eduard13 self-assigned this Jul 6, 2020
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @engcom-Charlie, could you please review the failing WebAPI Test?
Thank you for your contribution.

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Jul 6, 2020
@eduard13 eduard13 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix labels Jul 6, 2020
@ghost ghost added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels Jul 6, 2020
@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Jul 6, 2020
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Looks like the failing test isn't related with the current changes.

@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Jul 7, 2020
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-7787 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 8, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 8, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Tested according to the steps, described in comment

Manual testing scenario:

  1. Created a simple Product with Value Zero for "New Attribute";

Screenshot from 2020-07-08 17-27-38

  1. Try to create a new configurable product for the simple via Rest API:
    POST /V1/products

Screenshot from 2020-07-08 16-22-41

Before: ✖️ Exception thrown: Product with id "%1" does not contain required attribute "%2"."

Screenshot from 2020-07-08 16-22-49

After: ✔️ Configurable Product was created with the linked simple product

Screenshot from 2020-07-08 18-13-42
Screenshot from 2020-07-08 18-14-39

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 8, 2020
@engcom-Echo engcom-Echo self-assigned this Jul 9, 2020
@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 9, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 16, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jul 16, 2020
@magento-engcom-team magento-engcom-team merged commit faade59 into magento:2.4-develop Jul 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 18, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: ConfigurableProduct Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Configurable Product Links Validation Bug when int value is 0
5 participants