Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix robots.txt not store specific #29331

Merged
merged 3 commits into from
Aug 8, 2020
Merged

Fix robots.txt not store specific #29331

merged 3 commits into from
Aug 8, 2020

Conversation

engcom-Charlie
Copy link
Contributor

Description (*)

Fixed and covered by test

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Sitemap in robots.txt not store specific #28901

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jul 30, 2020
@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@magento magento deleted a comment from m2-assistant bot Jul 30, 2020
@ihor-sviziev ihor-sviziev self-assigned this Jul 30, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jul 30, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jul 31, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7924 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 31, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 31, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Create Second Web Site, Store and Store View

  2. Go to Stores -> Configuration -> General -> Web

  3. Set "Add Store Code to Urls" = "Yes" -> Save

  4. Go to Stores -> Configuration -> Catalog -> XML Sitemap

  5. Expand "Generation Settings" section

  6. Set "Enabled" = "Yes"

  7. Expand "Search Engine Submission Settings" section

  8. Set "Enable Submission to Robots.txt" = "Yes" -> Save

  9. Run php bin/magento cron:run and php bin/magento c:f

  10. Go to Marketing -> Site Map

  11. Create 2 Site Maps (one for Default site and another one for second with different "Filename"
    Screenshot from 2020-07-31 11-34-38

  12. Run php bin/magento cron:run and php bin/magento c:f

  13. Go to store view and open Default store (http://youredomain.local/robots.txt)

  14. Then in new tab open Second store (http://youredomain.local/second_website_store_view/robots.txt)

Before: ✖️ Site maps are the same

✔️ Default store view

2020-07-31_11-37

✖️ Second Website Store View

2020-07-31_11-39

After:

✔️ Default store view

2020-07-31_11-37

✔️ Second Website Store View

2020-07-31_12-17

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 31, 2020
@engcom-Echo engcom-Echo self-assigned this Jul 31, 2020
@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 31, 2020
@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Review in Progress in Pull Requests Dashboard Aug 6, 2020
@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Aug 6, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7924 has been created to process this Pull Request

@ihor-sviziev ihor-sviziev mentioned this pull request Aug 6, 2020
Closed
4 tasks
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Aug 7, 2020
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Aug 7, 2020 •
edited
Loading

✔️ QA Passed

After: ✔️ Default store view

Screenshot from 2020-08-07 11-45-30

After: ✔️ Second Website Store View

Screenshot from 2020-08-07 11-46-07

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Aug 7, 2020
@engcom-Echo engcom-Echo added QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 7, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 7, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 7, 2020
@slavvka slavvka mentioned this pull request Aug 8, 2020
Closed
4 tasks
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2020
@slavvka
ENGCOM-7924: Fix robots.txt not store specific #29331
4e1d900
@magento-engcom-team magento-engcom-team merged commit a5e8f01 into magento:2.4-develop Aug 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 8, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Sitemap Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sitemap in robots.txt not store specific
5 participants
@engcom-Charlie @magento-engcom-team @engcom-Alfa @ihor-sviziev @engcom-Echo