Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed critical error: The following tag(s) are not allowed: img #29863

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Fixed critical error: The following tag(s) are not allowed: img #29863

merged 2 commits into from
Sep 10, 2020

Conversation

themystery404
Copy link

@themystery404 themystery404 commented Sep 2, 2020 •
edited by m2-assistant bot
Loading

Description (*)

My account -> My orders pages generates critical error logs
Details: #25418 (comment)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes remove script tag #25418

Manual testing scenarios (*)

  1. Place an order as a registered customer.
  2. Go to My Account -> My Orders

Actual result:
All order pages (order, invoice, creditmemo, shipping) generates critical error in log
The following tag(s) are not allowed: img

Expected result:
no errors

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fixed critical error: The following tag(s) are not allowed: img #29958: Fixed critical error: The following tag(s) are not allowed: img

@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @themystery404. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 2, 2020
@themystery404 themystery404 mentioned this pull request Sep 2, 2020
Merged
4 tasks
@torhoehn torhoehn self-requested a review September 2, 2020 10:12
@torhoehn torhoehn self-assigned this Sep 2, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Sep 2, 2020
@torhoehn
Copy link
Contributor

torhoehn commented Sep 2, 2020

@themystery404 Thanks for your first contribution!

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, thank you for the review.
ENGCOM-8118 has been created to process this Pull Request
✳️ @torhoehn, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@themystery404 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 2, 2020
@torhoehn
Copy link
Contributor

torhoehn commented Sep 4, 2020

@magento run all tests

@engcom-Delta engcom-Delta self-assigned this Sep 7, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 7, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked order pages (order, invoice, creditmemo, shipping) dont generate errors in log
Before:
✔️ image
❌ Error "main.CRITICAL: The following tag(s) are not allowed: img [] []" in log

After:
✔️ image
✔️ No errors in log

@engcom-Delta
Copy link
Contributor

⚠️ Note: Static Tests are failed

@engcom-Delta engcom-Delta moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 7, 2020
@engcom-Charlie engcom-Charlie self-assigned this Sep 7, 2020
@torhoehn
Copy link
Contributor

torhoehn commented Sep 7, 2020

@themystery404 Could you please fix failing static test?

@engcom-Charlie
Copy link
Contributor

@torhoehn I'll fix static tests.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@ghost ghost moved this from Extended Testing (optional) to Ready for Testing in Pull Requests Dashboard Sep 8, 2020
@torhoehn
Copy link
Contributor

torhoehn commented Sep 8, 2020

@engcom-Charlie Thanks for fixing static tests!

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, thank you for the review.
ENGCOM-8118 has been created to process this Pull Request
✳️ @torhoehn, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 9, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 9, 2020
Closed
@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 10, 2020
@engcom-Delta
Copy link
Contributor

Note: All tests are passed

@engcom-Delta engcom-Delta moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Sep 10, 2020
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 10, 2020
@gabrieldagama
ENGCOM-8118: Fixed critical error: The following tag(s) are not allow…
012a537 
…ed: img #29863
@magento-engcom-team magento-engcom-team merged commit dbec1ff into magento:2.4-develop Sep 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2020

Hi @themystery404, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torhoehn torhoehn torhoehn approved these changes

Assignees

@torhoehn torhoehn

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Sales Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fixed critical error: The following tag(s) are not allowed: img
7 participants
@themystery404 @torhoehn @magento-engcom-team @engcom-Delta @engcom-Charlie @ihor-sviziev @sidolov