Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced MediaGalleryRenditions and MediaGalleryRenditionsApi modules #29889

Merged
merged 10 commits into from
Sep 11, 2020
Merged

Introduced MediaGalleryRenditions and MediaGalleryRenditionsApi modules #29889

merged 10 commits into from
Sep 11, 2020

Conversation

sivaschenko
Copy link
Member

@sivaschenko sivaschenko commented Sep 3, 2020

Description (*)

Introduced MediaGalleryRenditions and MediaGalleryRenditionsApi modules

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/321
https://github.com/magento/partners-magento2-infrastructure/pull/34

Fixed Issues (if relevant)

Fixes magento/adobe-stock-integration#1286

Approval Request

https://jira.corp.magento.com/browse/MC-37383

Manual testing scenarios (*)

  1. Insert image from media gallery to content - rendition instead of original image should be insterted
  2. Stores -> Configuration -> System -> Media Gallery Renditions configuration change should update all existing renditions (bin/magento queue:consumers:start media.gallery.renditions.update) and used for new renditions creation
  3. Rendition should be removed from filesystem when the corresponding asset is removed

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 3, 2020

Hi @sivaschenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 3, 2020
@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Sep 3, 2020
@sivaschenko
Copy link
Member Author

@magento run all tests

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Sep 3, 2020
@ghost ghost assigned sivaschenko Sep 3, 2020
@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 4, 2020
@sivaschenko
Copy link
Member Author

The changes are covered by new integration tests as well as existing MFTF tests

@sivaschenko
Copy link
Member Author

@magento run all tests

@ghost ghost moved this from Changes Requested to Waiting Related PRs in Pull Requests Dashboard Sep 4, 2020
@ghost ghost removed the Progress: needs update label Sep 4, 2020
@ghost ghost added the Progress: accept label Sep 10, 2020
@ghost ghost moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 10, 2020
@ghost ghost moved this from Merge in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 10, 2020
@ghost ghost moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 10, 2020
@ghost ghost moved this from Merge in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 10, 2020
@ghost ghost moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 10, 2020
@ghost ghost moved this from Merge in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 10, 2020
@sivaschenko sivaschenko moved this from Extended Testing (optional) to Testing in Progress in Pull Requests Dashboard Sep 10, 2020
@ghost ghost moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Sep 10, 2020
@magento-engcom-team magento-engcom-team merged commit e53891f into magento:2.4-develop Sep 11, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 11, 2020

Hi @sivaschenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryRenditions Component: MediaGalleryRenditionsApi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Story 54: User inserts image rendition to the content
5 participants