Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong typo function name #29986

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Fix wrong typo function name #29986

merged 2 commits into from
Nov 13, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Sep 10, 2020 •
edited
Loading

Description (*)

Correct function name caused by typo

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. From admin dashboard
  2. Go to catalog > Category
  3. Go to workarounds new category field
  4. All function should work without break

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix wrong typo function name #29987: Fix wrong typo function name

@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 10, 2020
@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Sep 10, 2020
@sidolov
Copy link
Contributor

sidolov commented Sep 10, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 10, 2020
Closed
@ihor-sviziev ihor-sviziev self-assigned this Sep 10, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Sep 10, 2020
@ihor-sviziev ihor-sviziev moved this from Pending Review to Review in Progress in Pull Requests Dashboard Sep 10, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Sep 11, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8181 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Oct 16, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Oct 16, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked create and save new category, edit existing category. All values from category form are saved, no errors occur

@engcom-Delta engcom-Delta added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Oct 20, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Oct 20, 2020
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Oct 23, 2020 •
edited
Loading

@engcom-Delta @engcom-Alfa seems like you missed to move this PR further in QA process?

@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@engcom-Delta engcom-Delta moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Oct 26, 2020
@gabrieldagama
Copy link
Contributor

@magento run all tests

@m2-community-project m2-community-project bot moved this from Merge in Progress to Ready for Testing in Pull Requests Dashboard Nov 13, 2020
magento-engcom-team pushed a commit that referenced this pull request Nov 13, 2020
@gabrieldagama
ENGCOM-8181: Fix wrong typo function name #29986
8e2b4f0
@magento-engcom-team magento-engcom-team merged commit 4631db8 into magento:2.4-develop Nov 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 13, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov moved this from Ready for Testing to Recently Merged in Pull Requests Dashboard Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@parkerthegeniuschild parkerthegeniuschild parkerthegeniuschild approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Ui Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for testing QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix wrong typo function name
8 participants
@mrtuvn @sidolov @ihor-sviziev @magento-engcom-team @engcom-Delta @gabrieldagama @parkerthegeniuschild @engcom-Alfa