-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal content with good message format for newlines #30014
Modal content with good message format for newlines #30014
Conversation
Hi @lfluvisotto. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@ihor-sviziev could you have a look also on this pr? |
@magento run all tests |
Hi @ihor-sviziev, thank you for the review. |
Hi @ptylek, thank you for the review. |
✔️ QA Passed Manual testing scenario:
Before: ✖️ Modal content with bad message format for newlines. After: ✔️ Modal content with correct message format for newlines. |
Hi @lfluvisotto, thank you for your contribution! |
Description (*)
Modal content with good message format for newlines
Fixed Issues (if relevant)
Fixes #30013
Manual testing scenarios (*)
Questions or comments
N/A
Contribution checklist (*)