Pass custom attributes to current link via XML #30070

mattkrupnik · 2020-09-16T08:29:15Z

Description (*)

Actualy we are able to add custom attributes for links in customer account navigation via XML for example:

    <referenceBlock name="customer-account-navigation-account-link">
        <arguments>
            <argument name="attributes" xsi:type="array">
                <item name="class" xsi:type="string">account-custom-class</item>
            </argument>
        </arguments>
    </referenceBlock>

But when customer-account-navigation-account-link is as current page in this case it is https://sample.com/customer/account/ our custom attribute dosn't show because method getAttributesHtml() isn't used for current link.

For non-current link method getAttributesHtml() is used.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Pass custom attributes to current link via XML #38500: Pass custom attributes to current link via XML

Add possibility to pass custom attributes from XML to current link.

m2-assistant · 2020-09-16T08:29:17Z

Hi @mattkrupnik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mattkrupnik · 2020-09-16T08:33:15Z

@magento run all tests

rogyar

Hi @mattkrupnik. Thank you for your contribution. Could I ask you to extend the description slightly by adding information about what problem we are trying to solve, please? Also, you may add a note that the introduced approach exists for a non-current link.

Also, please, take a look at the failing B2B Unit tests. It looks like there's an assertion that needs to be adjusted.

Thank you!

sidolov

@mattkrupnik please, sign Adobe CLA

mattkrupnik · 2020-09-16T20:20:50Z

@magento run Unit Tests

rogyar · 2020-09-21T14:35:51Z

@magento run Unit Tests

rogyar · 2020-09-22T06:57:49Z

@magento run all tests

mattkrupnik · 2021-05-06T20:09:39Z

@mattkrupnik please, sign Adobe CLA

@sidolov Can you approve? Your change request were realised.

magento-automated-testing · 2021-10-25T21:21:40Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mattkrupnik · 2022-02-02T10:27:12Z

@magento run all tests

magento-automated-testing · 2022-02-02T10:27:19Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mattkrupnik · 2022-02-02T10:28:02Z

@rogyar @sidolov Could you finish your review please?

mattkrupnik · 2023-01-03T11:59:47Z

@magento run all tests

magento-automated-testing · 2023-01-03T11:59:55Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Delta · 2024-03-08T12:15:55Z

@magento create issue

engcom-Dash · 2024-09-13T10:18:09Z

@magento run all tests

engcom-Dash · 2024-09-13T13:18:32Z

Hi @mattkrupnik ,

Thanks for the collaboration & contribution!

✔️ QA Passed
Preconditions:

Install fresh Magento 2.4-develop
Steps to reproduce
As per the Description.
Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

engcom-Dash · 2024-09-13T13:35:20Z

@magento run all tests

engcom-Dash · 2024-09-16T09:44:25Z

@magento run all tests

engcom-Dash · 2024-09-16T12:51:30Z

Failing tests seem flaky and Jira ticket has been created for these flaky test.

Build results:
Functional Tests EE:
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30070/7edab7b6989a7a497c545847e955ed94/Functional/allure-report-ee/index.html#categories/a644910ae0cb11e839a98baa21929b76/186e196d98c99d3a/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30070/7edab7b6989a7a497c545847e955ed94/Functional/allure-report-ee/index.html

See Jira:
Jira 2

So moving it to a further status.

engcom-Dash · 2024-09-18T07:08:50Z

@magento run Functional Tests CE, Functional Tests CE

Update Current.php

526b9d7

Add possibility to pass custom attributes from XML to current link.

ghost added the Progress: pending review label Sep 16, 2020

magento-engcom-team added Component: View Release Line: 2.4 labels Sep 16, 2020

rogyar requested changes Sep 16, 2020

View reviewed changes

ghost assigned rogyar Sep 16, 2020

ghost added Progress: needs update and removed Progress: pending review labels Sep 16, 2020

sidolov requested changes Sep 16, 2020

View reviewed changes

ghost assigned sidolov Sep 16, 2020

sidolov added Priority: P3 May be fixed according to the position in the backlog. Risk: medium Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 16, 2020

mattkrupnik requested a review from sidolov September 16, 2020 19:36

mattkrupnik changed the title ~~Pass custom attributes to current link via XML~~ [WIP]Pass custom attributes to current link via XML Sep 16, 2020

Changed way to add method to current link

8122c94

mattkrupnik changed the title ~~[WIP]Pass custom attributes to current link via XML~~ Pass custom attributes to current link via XML Sep 16, 2020

mattkrupnik requested a review from rogyar September 17, 2020 16:34

Merge branch '2.4-develop' into mattkrupnik-patch-1

8c2c6b8

engcom-Charlie self-assigned this Sep 24, 2020

ghost added Progress: pending review and removed Progress: needs update labels Sep 24, 2020

ghost added Progress: review and removed Progress: pending review labels Oct 1, 2020

mattkrupnik requested review from dudzio12, rogyar and sidolov and removed request for rogyar, sidolov and dudzio12 January 3, 2023 11:59

Merge branch '2.4-develop' into mattkrupnik-patch-1

0df4fff

m2-assistant bot mentioned this pull request Mar 8, 2024

[Issue] Pass custom attributes to current link via XML #38500

Closed

4 tasks

engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 18, 2024

Priyakshic added the Project: Community Picked PRs upvoted by the community label Sep 12, 2024

Merge branch '2.4-develop' into mattkrupnik-patch-1

ffdfdad

engcom-Dash self-assigned this Sep 13, 2024

engcom-Dash and others added 2 commits September 13, 2024 19:03

30070: Improve PHPDoc for property

7787324

Merge branch '2.4-develop' into mattkrupnik-patch-1

9011bec

Merge branch '2.4-develop' into mattkrupnik-patch-1

3debd1a

magento-devops-reposync-svc merged commit 4267628 into magento:2.4-develop Oct 18, 2024
11 of 12 checks passed

Pass custom attributes to current link via XML #30070

Pass custom attributes to current link via XML #30070

Uh oh!

Conversation

mattkrupnik commented Sep 16, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Sep 16, 2020

Uh oh!

mattkrupnik commented Sep 16, 2020

Uh oh!

rogyar left a comment

Choose a reason for hiding this comment

Uh oh!

sidolov left a comment

Choose a reason for hiding this comment

Uh oh!

mattkrupnik commented Sep 16, 2020

Uh oh!

rogyar commented Sep 21, 2020

Uh oh!

rogyar commented Sep 22, 2020

Uh oh!

mattkrupnik commented May 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magento-automated-testing bot commented Oct 25, 2021

Uh oh!

mattkrupnik commented Feb 2, 2022

Uh oh!

magento-automated-testing bot commented Feb 2, 2022

Uh oh!

mattkrupnik commented Feb 2, 2022

Uh oh!

mattkrupnik commented Jan 3, 2023

Uh oh!

magento-automated-testing bot commented Jan 3, 2023

Uh oh!

engcom-Delta commented Mar 8, 2024

Uh oh!

engcom-Dash commented Sep 13, 2024

Uh oh!

engcom-Dash commented Sep 13, 2024

Uh oh!

engcom-Dash commented Sep 13, 2024

Uh oh!

engcom-Dash commented Sep 16, 2024

Uh oh!

engcom-Dash commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Dash commented Sep 18, 2024

Uh oh!

Uh oh!

Uh oh!

mattkrupnik commented Sep 16, 2020 •

edited by m2-assistant bot

Loading

mattkrupnik commented May 6, 2021 •

edited

Loading

engcom-Dash commented Sep 16, 2024 •

edited

Loading