[MFTF] add ReloadPageActionGroup #30223

Usik2203 · 2020-09-28T20:20:59Z

This PR add ReloadPageActionGroup and use it instead
<reloadPage stepKey="refreshPage"/>
<waitForPageLoad stepKey="waitForPageLoad2"/>

Resolved issues:

resolves [Issue] [MFTF] add ReloadPageActionGroup #30683: [MFTF] add ReloadPageActionGroup

m2-assistant · 2020-09-28T20:21:02Z

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Usik2203 · 2020-09-28T20:21:16Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

rogyar · 2020-09-29T17:49:08Z

@magento run Functional Tests EE, Functional Tests B2B

lbajsarowicz · 2020-09-29T18:49:09Z

app/code/Magento/AdminAnalytics/Test/Mftf/Test/AdminCheckAnalyticsTrackingTest.xml

-        <waitForPageLoad stepKey="waitForPageReloaded"/>
+        <actionGroup ref="ReloadPageActionGroup" stepKey="pageReload"/>


It was written incorrect way ( 🤦🏻 ) so that your change is now backwards compatible.

To be backwards-compatible, you should keep old stepKey which is the extremely dirty way.
If we can introduce this in Magento 2.5 branch - then it would be not an issue.

Hi @lbajsarowicz
I have reverted changes for this file.
thanks

Usik2203 · 2020-10-17T15:19:44Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

rogyar · 2020-10-20T13:18:23Z

...to/Checkout/Test/Mftf/Test/StorefrontPersistentDataForGuestCustomerWithPhysicalQuoteTest.xml

@@ -49,8 +49,7 @@
        <waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappearAfterFlatRateSelection"/>
        <see selector="{{CheckoutCartSummarySection.total}}" userInput="15" stepKey="assertOrderTotalField"/>
        <!-- 5. Refresh browser page (F5) -->
-        <reloadPage stepKey="reloadPage"/>
-        <waitForPageLoad stepKey="waitForPageLoad"/>


We still may consider this change as BiC (there might be extensions with before/after references to this step key). The common (a little bit dirty but still common) practice, in this case, will be replacing the old action with a comment that has the same stepKey. Example is below

<comment userInput="Adding comment to replace reload action and preserve Backward Compatibility" stepKey="waitForPageLoad" />

Hope it makes sense.

Hi @rogyar
Done
Thank you for advice.

Usik2203 · 2020-10-24T14:17:06Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

engcom-Charlie · 2020-10-26T12:10:10Z

@magento run all tests

lbajsarowicz

✔️ Thanks for the adjustments, everything looks correct now.

magento-engcom-team · 2020-10-27T10:30:03Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-8394 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Bravo · 2020-10-28T10:08:54Z

QA not applicable

engcom-Charlie · 2020-10-28T10:15:30Z

@magento create issue

gabrieldagama · 2020-10-29T10:31:03Z

@magento run Semantic Version Checker

m2-assistant · 2020-11-09T14:22:20Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

add new ReloadPageActionGroup

9713cde

ghost added this to Pending Review in Pull Requests Dashboard Sep 28, 2020

ghost added the Progress: pending review label Sep 28, 2020

magento-engcom-team added Component: multiple Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 28, 2020

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 28, 2020

rogyar self-assigned this Sep 29, 2020

lbajsarowicz reviewed Sep 29, 2020

View reviewed changes

ghost assigned lbajsarowicz Sep 29, 2020

sidolov moved this from Pending Review to Review in Progress in Pull Requests Dashboard Oct 1, 2020

ghost added Progress: review and removed Progress: pending review labels Oct 1, 2020

revert changes

52a288b

ghost assigned Usik2203 Oct 17, 2020

Merge branch '2.4-develop' into add-ReloadPageActionGroup

9de5f78

rogyar requested changes Oct 20, 2020

View reviewed changes

ghost moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Oct 20, 2020

ghost added Progress: needs update and removed Progress: review labels Oct 20, 2020

Usik2203 added 2 commits October 24, 2020 17:13

add Backward Compatibility

bb7d50b

Merge branch '2.4-develop' into add-ReloadPageActionGroup

73951dd

Usik2203 removed their assignment Oct 24, 2020

engcom-Charlie self-assigned this Oct 26, 2020

engcom-Charlie requested review from rogyar and lbajsarowicz October 27, 2020 08:52

engcom-Charlie moved this from Changes Requested to Pending Review in Pull Requests Dashboard Oct 27, 2020

ghost added Progress: pending review and removed Progress: needs update labels Oct 27, 2020

lbajsarowicz approved these changes Oct 27, 2020

View reviewed changes

ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Oct 27, 2020

ghost added Progress: ready for testing and removed Progress: pending review labels Oct 27, 2020

engcom-Bravo moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Oct 28, 2020

engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Oct 28, 2020

engcom-Charlie added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 28, 2020

m2-assistant bot mentioned this pull request Oct 28, 2020

[Issue] [MFTF] add ReloadPageActionGroup #30683

Closed

engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Oct 28, 2020

engcom-Charlie added Progress: accept and removed Progress: ready for testing labels Oct 28, 2020

magento-engcom-team pushed a commit that referenced this pull request Nov 9, 2020

ENGCOM-8394: [MFTF] add ReloadPageActionGroup #30223

e537a9a

magento-engcom-team merged commit 4397050 into magento:2.4-develop Nov 9, 2020

sidolov moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Nov 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MFTF] add ReloadPageActionGroup #30223

[MFTF] add ReloadPageActionGroup #30223

Usik2203 commented Sep 28, 2020 •

edited by m2-assistant bot

Loading

m2-assistant bot commented Sep 28, 2020

Usik2203 commented Sep 28, 2020

rogyar commented Sep 29, 2020

lbajsarowicz Sep 29, 2020

Usik2203 Oct 17, 2020

Usik2203 commented Oct 17, 2020

rogyar Oct 20, 2020

Usik2203 Oct 24, 2020

Usik2203 commented Oct 24, 2020

engcom-Charlie commented Oct 26, 2020

lbajsarowicz left a comment

magento-engcom-team commented Oct 27, 2020

engcom-Bravo commented Oct 28, 2020

engcom-Charlie commented Oct 28, 2020

gabrieldagama commented Oct 29, 2020

m2-assistant bot commented Nov 9, 2020

		<waitForPageLoad stepKey="waitForPageReloaded"/>
		<actionGroup ref="ReloadPageActionGroup" stepKey="pageReload"/>

[MFTF] add ReloadPageActionGroup #30223

[MFTF] add ReloadPageActionGroup #30223

Conversation

Usik2203 commented Sep 28, 2020 • edited by m2-assistant bot Loading

Resolved issues:

m2-assistant bot commented Sep 28, 2020

Usik2203 commented Sep 28, 2020

rogyar commented Sep 29, 2020

lbajsarowicz Sep 29, 2020

Choose a reason for hiding this comment

Usik2203 Oct 17, 2020

Choose a reason for hiding this comment

Usik2203 commented Oct 17, 2020

rogyar Oct 20, 2020

Choose a reason for hiding this comment

Usik2203 Oct 24, 2020

Choose a reason for hiding this comment

Usik2203 commented Oct 24, 2020

engcom-Charlie commented Oct 26, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Oct 27, 2020

engcom-Bravo commented Oct 28, 2020

engcom-Charlie commented Oct 28, 2020

gabrieldagama commented Oct 29, 2020

m2-assistant bot commented Nov 9, 2020

Usik2203 commented Sep 28, 2020 •

edited by m2-assistant bot

Loading