Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Login As Customer Log - Logged In must be DateRange Filter instead of Text filter, Date display wrong timezone issue30328 #30329

Merged
merged 18 commits into from
Mar 7, 2021
Merged

Resolve Login As Customer Log - Logged In must be DateRange Filter instead of Text filter, Date display wrong timezone issue30328 #30329

merged 18 commits into from
Mar 7, 2021

Conversation

edenduong
Copy link
Contributor

@edenduong edenduong commented Oct 3, 2020 •
edited by engcom-Hotel
Loading

Description (*)

Resolve Login As Customer Log - Logged In must be DateRange Filter instead of Text filter, Date display wrong timezone issue30328

I resolve it by changing the XML - magento native support and can find so many files in Magento core so I think I don't code Automation Test for this PR.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/398

Fixed Issues (if relevant)

  1. Fixes Login As Customer Log - Logged In must be DateRange Filter instead of Text filter, Date display wrong timezone #30328: Login As Customer Log - Logged In must be DateRange Filter instead of Text filter, Date display wrong timezone

Manual testing scenarios (*)

  1. Go to Customer -> Login as customer log

Expected result

  1. Date Range filter

image

  1. Time zone converted
    image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@edenduong
Login As Customer Log - Logged In must be DateRange Filter instead of…
eeb47dd 
… Text filter, Date display wrong timezone issue30328
@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2020

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Oct 3, 2020
@edenduong
Copy link
Contributor Author

@magento run all tests

@rogyar
Copy link
Contributor

rogyar commented Oct 5, 2020

Hi @edenduong. Thank you for your collaboration. May I ask you to cover this fix with an MFTF or integration test, please?

Thank you!

@rogyar rogyar self-assigned this Oct 5, 2020
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 5, 2020
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 6, 2020
@sidolov sidolov moved this from Pending Review to Review in Progress in Pull Requests Dashboard Oct 6, 2020
@gabrieldagama gabrieldagama removed the Priority: P3 May be fixed according to the position in the backlog. label Oct 20, 2020
gabrieldagama
gabrieldagama suggested changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing state as waiting for contributor response.

@engcom-Hotel can you help with test coverage on this?

Thank you!

@ghost ghost moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Oct 20, 2020
@ghost ghost assigned gabrieldagama Oct 20, 2020
@engcom-Hotel engcom-Hotel self-assigned this Oct 21, 2020
@engcom-Hotel
Copy link
Contributor

@gabrieldagama sure

@ghost ghost removed the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Oct 22, 2020
@engcom-Hotel
Copy link
Contributor

@magento run all tests

1 similar comment
@engcom-Delta
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests CE

2 similar comments
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests CE

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests CE

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Jan 11, 2021
@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8424 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Jan 11, 2021
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Jan 12, 2021
@engcom-Alfa engcom-Alfa moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Jan 12, 2021
@gabrieldagama
Copy link
Contributor

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Mar 7, 2021
@gabrieldagama
ENGCOM-8424: Resolve Login As Customer Log - Logged In must be DateRa…
1def3d4 
…nge Filter instead of Text filter, Date display wrong timezone issue30328 #30329
@magento-engcom-team magento-engcom-team merged commit 93d5c34 into magento:2.4-develop Mar 7, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 7, 2021

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar left review comments

@engcom-Hotel engcom-Hotel engcom-Hotel left review comments

@gabrieldagama gabrieldagama gabrieldagama approved these changes

Assignees

@rogyar rogyar

@gabrieldagama gabrieldagama

@engcom-Alfa engcom-Alfa

@engcom-Hotel engcom-Hotel

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: LoginAsCustomer Component: LoginAsCustomerLog Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. tech-partners-contribution Technology Partner: Magestore Type: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login As Customer Log - Logged In must be DateRange Filter instead of Text filter, Date display wrong timezone
8 participants
@edenduong @rogyar @engcom-Hotel @engcom-Delta @magento-engcom-team @engcom-Alfa @gabrieldagama @sidolov