[GraphQl] Get product reviews will filter by store Id #30338

huykon · 2020-10-05T04:22:37Z

Description (*)

Get product reviews will filter by Store Id

Related Pull Requests

Fixed Issues (if relevant)

Fixes [GraphQl] Get product reviews is not filter by store Id #30337

Manual testing scenarios (*)

Query get product reviews by push header Store=store_code
Try this query with each storeview then see the result.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-10-05T04:22:39Z

Hi @huykon. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

rogyar

Hi @huykon. Thank you for providing this improvement. According to definition of done , all changes should be covered by autotests.

Please, cover this case with an API-functional test. The test will repeat the "Steps to reproduce" from the original issue.

Thank you.

rogyar · 2020-10-05T06:28:53Z

app/code/Magento/ReviewGraphQl/Model/DataProvider/ProductReviewsDataProvider.php

    {
        /** @var Collection $reviewsCollection */
        $reviewsCollection = $this->collectionFactory->create()
+	        ->addStoreFilter($storeId)


Please, fix indentation to match the other lines of code.

rogyar · 2020-10-05T06:29:02Z

app/code/Magento/ReviewGraphQl/Model/Resolver/Product/Reviews.php

@@ -91,12 +92,16 @@ public function resolve(
            throw new GraphQlInputException(__('pageSize value must be greater than 0.'));
        }

+	    /** @var StoreInterface $store */
+	    $store = $context->getExtensionAttributes()->getStore();


Please, fix indentation to match the other lines of code.

rogyar · 2020-10-05T06:29:08Z

app/code/Magento/ReviewGraphQl/Model/Resolver/Product/Reviews.php

        /** @var Product $product */
        $product = $value['model'];
        $reviewsCollection = $this->productReviewsDataProvider->getData(
            (int) $product->getId(),
            $args['currentPage'],
-            $args['pageSize']
+            $args['pageSize'],
+	        (int) $store->getId()


Please, fix indentation to match the other lines of code.

huykon · 2020-10-05T07:34:39Z

@magento run all tests

huykon · 2020-10-08T09:01:47Z

@magento run all tests

huykon · 2020-10-09T02:50:53Z

@magento run Static Tests

huykon · 2020-10-09T03:32:31Z

@magento run WebAPI Tests

huykon · 2020-10-12T02:49:06Z

@magento run WebAPI Tests

rogyar · 2020-10-14T14:30:06Z

Hi @huykon. It looks like there's something wrong with inserting review into the database in the fixture. Please, refer to the following logs for more details
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30338/a30c75791314044d36f1a61f4bede3bf/WebApi/console-error-logs.html

huykon · 2020-10-14T14:31:41Z

@rogyar That's right. I am facing with problem when create test case on specific store id. Please help

rogyar

Hi @huykon. Please, check my comments below. Hope it will help with the failing tests.

rogyar · 2020-10-19T12:58:08Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Review/GetProductReviewsTest.php

@@ -199,6 +199,63 @@ public function testProductReviewRatings()
        self::assertNotEmpty($items[0]['reviews']['items']);
    }

+    /**
+     * @magentoApiDataFixture Magento/Review/_files/different_reviews_different_stores.php
+     * @magentoApiDataFixture Magento/Store/_files/second_store.php


It looks like your first fixture depends on the second one. That's the main reason of the failing tests. Try to change the order of fixtures loading

rogyar · 2020-10-19T12:59:22Z

dev/tests/integration/testsuite/Magento/Review/_files/different_reviews_different_stores.php

+    [
+        $secondStoreId
+    ]
+)->save();


Please, do not use deprecated methods. Use a resource model for saving the entity instead.

Thanks

@rogyar I have seen some file use that method so I duplicate to this file. Can you tell me which method can I use?

huykon · 2020-10-19T13:14:54Z

@magento run WebAPI Tests

huykon · 2020-10-19T15:01:01Z

@magento run WebAPI Tests

huykon · 2020-10-20T01:15:32Z

@magento run all tests

huykon · 2020-10-20T08:13:58Z

@rogyar can you check what problem with my PR?

rogyar · 2020-10-24T11:31:11Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Review/GetProductReviewsTest.php

@@ -204,7 +281,7 @@ public function testProductReviewRatings()
     */
    public function testCustomerReviewsAddedToProduct()
    {
-        $query = <<<QUERY
+        $query             = <<<QUERY


Hi @huykon. Could I ask you to double-check the indentation for all your changes, please? I'm not sure what happened but for some reason, we have unnecessary spaces here and there.

Thanks.

huykon · 2020-10-25T07:26:05Z

@magento run all tests

rogyar · 2020-10-28T14:40:12Z

Hi @huykon. Please, check my comment regarding the deprecated methods.

https://github.com/magento/magento2/pull/30338/files#r507725363

Thank you

huykon · 2020-10-29T09:37:35Z

@rogyar which method was deprecated?

rogyar · 2020-11-02T10:42:34Z

Hi @huykon. The ::save method of the AbstractModel is deprecated since Magento 2.1 (

magento2/lib/internal/Magento/Framework/Model/AbstractModel.php

Line 652 in 6729b6e

*/

). You use it for saving the review. Please, check my comment above, it highlights the exact place where you use it.

Thanks

huykon · 2020-11-02T10:46:23Z

@rogyar Thank you. So which method can I use to replace save method?

rogyar · 2020-11-02T10:50:30Z

Hi @huykon. Please, use a resource model or repository instead

huykon

Hi @huykon. Please, use a resource model or repository instead

Hi @rogyar , Can you make a snippet help me? I don't know which method replace of?

huykon · 2020-10-19T13:08:21Z

dev/tests/integration/testsuite/Magento/Review/_files/different_reviews_different_stores.php

+    [
+        $secondStoreId
+    ]
+)->save();


@rogyar I have seen some file use that method so I duplicate to this file. Can you tell me which method can I use?

fooman

@huykon I believe @rogyar was looking for something like in the suggested code changes.

fooman · 2021-05-07T02:35:06Z

dev/tests/integration/testsuite/Magento/Review/_files/different_reviews_different_stores.php

+    [
+        $secondStoreId
+    ]
+)->save();


Suggested change

)->save();

);

$reviewResourceModel->save($review);

Thanks @fooman I am trying your helpful.

dev/tests/integration/testsuite/Magento/Review/_files/different_reviews_different_stores.php

huykon · 2021-05-07T02:49:20Z

@magento run all tests

magento-automated-testing · 2021-05-07T02:49:24Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-November · 2023-03-27T14:48:09Z

Hi @huykon
we re-verified the issue on Magento 2.4-develop instance and after internal discussions, it has been concluded that this is expected behavior but not a bug. "productReviewRatingsMetadata" Graphql response behavior is as per Admin configuration but not based on front end ratings added. Stores - Configuration - Attributes - rating - select price and value - Set rating visibility to both stores and save. If the Graphql query is ran even before rating is added, both price and value are retrieved in the response since enabled in Admin configuration. Kindly refer the Magento docs.
Thank you.

gql get product reviews filter by storeId

c16649c

magento-engcom-team added the Component: ReviewGraphQl label Oct 5, 2020

ghost added the Progress: pending review label Oct 5, 2020

magento-engcom-team added the Release Line: 2.4 label Oct 5, 2020

rogyar self-assigned this Oct 5, 2020

rogyar requested changes Oct 5, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Oct 5, 2020

add storeId to test case

93e346a

sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S0 A problem that is blocking the ability to work. An immediate fix is needed. labels Oct 5, 2020

try add test case get product review with second storeview

3fb84b1

fix test

d1ecf8c

load testsuite store code

5030f72

engcom-Charlie self-assigned this Oct 13, 2020

engcom-Charlie removed their assignment Oct 19, 2020

rogyar requested changes Oct 19, 2020

View reviewed changes

re-format code

07d1780

load store by code

8092b4f

rogyar requested changes Oct 24, 2020

View reviewed changes

fix spaces

fcab16c

Merge branch '2.4-develop' into product/gql-product-review

d215272

huykon commented Nov 8, 2020

View reviewed changes

m2-community-project bot added Progress: review and removed Progress: needs update labels Nov 8, 2020

fooman reviewed May 7, 2021

View reviewed changes

m2-community-project bot assigned fooman May 7, 2021

huykon added 2 commits May 7, 2021 09:47

save by resourceModel

155728f

Merge branch '2.4-develop' into product/gql-product-review

1d29506

nrkapoor requested review from cpartica and rogyar February 28, 2022 01:22

nrkapoor assigned alena-marchenko and chernenm Nov 27, 2022

fooman removed their assignment Jul 2, 2025

[GraphQl] Get product reviews will filter by store Id #30338

Are you sure you want to change the base?

[GraphQl] Get product reviews will filter by store Id #30338

Conversation

huykon commented Oct 5, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Oct 5, 2020

Uh oh!

rogyar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huykon commented Oct 5, 2020

Uh oh!

huykon commented Oct 8, 2020

Uh oh!

huykon commented Oct 9, 2020

Uh oh!

huykon commented Oct 9, 2020

Uh oh!

huykon commented Oct 12, 2020

Uh oh!

rogyar commented Oct 14, 2020

Uh oh!

huykon commented Oct 14, 2020

Uh oh!

rogyar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huykon commented Oct 19, 2020

Uh oh!

huykon commented Oct 19, 2020

Uh oh!

huykon commented Oct 20, 2020

Uh oh!

huykon commented Oct 20, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huykon commented Oct 25, 2020

Uh oh!

rogyar commented Oct 28, 2020

Uh oh!

huykon commented Oct 29, 2020

Uh oh!

rogyar commented Nov 2, 2020

Uh oh!

huykon commented Nov 2, 2020

Uh oh!

rogyar commented Nov 2, 2020

Uh oh!

huykon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fooman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

engcom-November commented Mar 27, 2023 •

edited

Loading