Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphQl] The fields that described below has been deprecated #30694

Merged
merged 4 commits into from
Dec 4, 2020
Merged

[GraphQl] The fields that described below has been deprecated #30694

merged 4 commits into from
Dec 4, 2020

Conversation

andrewbess
Copy link
Contributor

@andrewbess andrewbess commented Oct 28, 2020 •
edited
Loading

Description (*)

This pull request (PR) adds the @deprecated directive to the fields that described below according to requirements issue #30625

ProductInterface

  • special_from_date
  • attribute_set_id
  • new_from_date
  • new_to_date
  • created_at
  • updated_at

CategoryInterface

  • created_at
  • updated_at

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes GraphQl public catalog endpoints expose some data that should not be visible #30625: GraphQl public catalog endpoints expose some data that should not be visible

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@andrewbess
CE#30625: The fields that described below has been deprecated
0ad4311 
- special_from_date
- attribute_set_id
- new_from_date
- new_to_date
- created_at
- updated_at
@m2-assistant
Copy link

m2-assistant bot commented Oct 28, 2020

Hi @andrewbess. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: CatalogGraphQl Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Oct 28, 2020
@ghost ghost added this to Pending Review in GraphQL Pull Requests Dashboard Oct 28, 2020
@andrewbess
Copy link
Contributor Author

@magento run all tests

@rogyar rogyar self-assigned this Oct 29, 2020
@ghost ghost moved this from Pending Review to Review in Progress in GraphQL Pull Requests Dashboard Oct 29, 2020
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 29, 2020
@ghost ghost added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Oct 29, 2020
rogyar
rogyar requested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrewbess.
Please, check the failing tests.
Thank you

@ghost ghost moved this from Review in Progress to Changes Requested in GraphQL Pull Requests Dashboard Oct 29, 2020
@andrewbess
Copy link
Contributor Author

Hello @rogyar
Thank you for your review.
The QueryComplexityLimiterTest tests have been fixed.
Waiting for finish.

@andrewbess
Copy link
Contributor Author

@magento run all tests

@nrkapoor nrkapoor added this to the 2.4.2 milestone Oct 30, 2020
@nrkapoor nrkapoor requested a review from akaplya October 30, 2020 23:40
@nrkapoor
Copy link

@akaplya @cpartica @mauragcyrus Can we prioritize this issue?

@andrewbess
CE#30625: The fields of the CategoryInterface have been deprecated
ebe6c10 
- created_at
- updated_at

Also, the tests have been fixed
@andrewbess
Copy link
Contributor Author

@magento run all tests

@andrewbess
Copy link
Contributor Author

@magento run Static Tests

@andrewbess
Copy link
Contributor Author

@magento run WebAPI Tests

@andrewbess
Copy link
Contributor Author

@magento run Unit Tests, Semantic Version Checker, Database Compare, Integration Tests, Magento Health Index, Sample Data Tests CE, Sample Data Tests EE, Sample Data Tests B2B

@andrewbess
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@andrewbess
Copy link
Contributor Author

@magento run Functional Tests EE, Functional Tests B2B

@m2-community-project m2-community-project bot moved this from Changes Requested to Ready for Testing in GraphQL Pull Requests Dashboard Nov 5, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8430 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit df831fe into magento:2.4-develop Dec 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 4, 2020

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@andrewbess andrewbess deleted the graphql/CE-30625 branch December 4, 2020 14:45
@nrkapoor nrkapoor moved this from Ready for Testing to Recently Merged in GraphQL Pull Requests Dashboard Dec 20, 2020
@keharper keharper mentioned this pull request Jan 28, 2021
Merged
@t-heuser t-heuser mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@cpartica cpartica cpartica approved these changes

@prabhuram93 prabhuram93 Awaiting requested review from prabhuram93

@mauragcyrus mauragcyrus Awaiting requested review from mauragcyrus

@akaplya akaplya Awaiting requested review from akaplya

Assignees

@rogyar rogyar

@andrewbess andrewbess

@cpartica cpartica

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: CatalogGraphQl Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Project: GraphQL Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
No open projects
GraphQL Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

GraphQl public catalog endpoints expose some data that should not be visible
6 participants
@andrewbess @nrkapoor @magento-engcom-team @rogyar @cpartica @sidolov