Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC-38788: setup:upgrade not possible in after installing Sample Data Magento #30928

Merged
merged 2 commits into from Nov 20, 2020

Conversation

engcom-Golf
Copy link
Contributor

Description (*)

Sample data install failed due to cron enabled. Fullsearch indexer deletes index in elasticsearch but not in local cache of installation process.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes setup:upgrade not possible in after installing Sample Data Magento 2.4.1  #30685

Manual testing scenarios (*)

  1. Magento installed
  2. Cron enabled via command
    bin/magento cron:install
  3. Elasticsearch enabled
  4. Install Sample data
  5. Run command
    bin/magento setup:upgrade

Expected result:

  1. Installation process finished without exceptions
  2. No sample data errors in var/system.log

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 16, 2020

Hi @engcom-Golf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Nov 16, 2020
@engcom-Golf
Copy link
Contributor Author

@magento run all tests

@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in High Priority Pull Requests Dashboard Nov 17, 2020
@engcom-Oscar engcom-Oscar moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Nov 18, 2020
@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 18, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Nov 18, 2020
@engcom-Foxtrot engcom-Foxtrot moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Nov 18, 2020
@engcom-Oscar engcom-Oscar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 18, 2020
@m2-community-project m2-community-project bot moved this from Merge in Progress to Ready for Testing in High Priority Pull Requests Dashboard Nov 18, 2020
@engcom-Kilo
Copy link
Contributor

@magento import pull request to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@engcom-Kilo the pull request successfully imported.

@magento-engcom-team magento-engcom-team merged commit 9de2802 into magento:2.4-develop Nov 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2020

Hi @engcom-Golf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Elasticsearch Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup:upgrade not possible in after installing Sample Data Magento 2.4.1
5 participants