Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Adding AdminSetStockStatusActionGroup #31013

Merged
merged 6 commits into from
Dec 10, 2020
Merged

[MFTF] Adding AdminSetStockStatusActionGroup #31013

merged 6 commits into from
Dec 10, 2020

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Nov 23, 2020 •
edited by m2-assistant bot
Loading

This PR provides new AdminSetStockStatusActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] Adding AdminSetStockStatusActionGroup #31034: [MFTF] Adding AdminSetStockStatusActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Nov 23, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Component: ConfigurableProduct Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 23, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@AnnaAPak AnnaAPak changed the title Adding AdminSetStockStatusActionGroup [MFTF] Adding AdminSetStockStatusActionGroup Nov 23, 2020
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Nov 23, 2020
@rogyar rogyar self-assigned this Nov 23, 2020
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Nov 23, 2020
rogyar
rogyar requested changes Nov 23, 2020
View reviewed changes
app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateProductAttributeRequiredTextFieldTest.xml Outdated
@@ -50,7 +50,7 @@
<waitForPageLoad stepKey="waitForProductToLoad"/>

<fillField selector="{{AdminProductFormSection.productQuantity}}" userInput="100" stepKey="fillProductQty"/>
<selectOption selector="{{AdminProductFormSection.productStockStatus}}" userInput="In Stock" stepKey="selectStockStatus"/>
<actionGroup ref="AdminSetStockStatusActionGroup" stepKey="selectStockStatus"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, specify values explicitly instead of using the default parameter value of the action group. In that way, we will make the test much more readable (don't need to go and check the default value for the parameter in the action group to figure out what value will be set in this action).

Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed this, thank you.

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Nov 23, 2020
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Requests Dashboard Nov 23, 2020
@gabrieldagama
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 24, 2020
Closed
@gabrieldagama gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 24, 2020
@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Requests Dashboard Nov 24, 2020
@AnnaAPak
Copy link
Contributor Author

Hi @rogyar, I have fixed this - sorry, it was my fault. Thanks.

@rogyar
Copy link
Contributor

rogyar commented Dec 1, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@engcom-Charlie engcom-Charlie self-assigned this Dec 1, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie moved this from Changes Requested to Pending Review in High Priority Pull Requests Dashboard Dec 3, 2020
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 4, 2020
@m2-community-project m2-community-project bot moved this from Pending Review to Changes Requested in High Priority Pull Requests Dashboard Dec 4, 2020
@m2-community-project m2-community-project bot moved this from Changes Requested to Ready for Testing in High Priority Pull Requests Dashboard Dec 4, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8515 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

QA not applicable. Moving the PR to Extended Testing colmn

@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 4, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Dec 4, 2020
magento-engcom-team pushed a commit that referenced this pull request Dec 10, 2020
@gabrieldagama
ENGCOM-8515: [MFTF] Adding AdminSetStockStatusActionGroup #31013
e10bfa4
@magento-engcom-team magento-engcom-team merged commit d315a9f into magento:2.4-develop Dec 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2020

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: ConfigurableProduct Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Adding AdminSetStockStatusActionGroup
6 participants
@AnnaAPak @gabrieldagama @rogyar @engcom-Charlie @magento-engcom-team @engcom-Bravo