Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Refactoring of Search actions on Storefront #31240

Merged
merged 11 commits into from
Jan 23, 2021
Merged

[MFTF] Refactoring of Search actions on Storefront #31240

merged 11 commits into from
Jan 23, 2021

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Dec 10, 2020 •
edited by m2-assistant bot
Loading

Description (*)

  • StorefrontAssertProductNameIsNotOnProductMainPageActionGroup has been added
  • Tests have been refactored with existing StorefrontCheckQuickSearchStringActionGroup, StorefrontAssertProductNameOnProductMainPageActionGroup and newly created StorefrontAssertProductNameIsNotOnProductMainPageActionGroup
    Please, note: AdminSubmitCategoriesPopupActionGroup (not related to search) has been added to some tests to prevent tests failure

Resolved issues:

  1. resolves [Issue] [MFTF] Refactoring of Search actions on Storefront #31251: [MFTF] Refactoring of Search actions on Storefront

@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Component: CatalogSearch Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 10, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@AnnaAPak AnnaAPak changed the title Refactoring of Search actions on Storefront [MFTF[ Refactoring of Search actions on Storefront Dec 10, 2020
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Dec 10, 2020
@AnnaAPak AnnaAPak changed the title [MFTF[ Refactoring of Search actions on Storefront [MFTF] Refactoring of Search actions on Storefront Dec 10, 2020
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 10, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 10, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 10, 2020
Closed
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Dec 10, 2020
@rogyar rogyar self-assigned this Dec 11, 2020
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Dec 11, 2020
rogyar
rogyar requested changes Dec 11, 2020
View reviewed changes
...talog/Test/Mftf/ActionGroup/StorefrontAssertProductNameIsNotOnProductMainPageActionGroup.xml Outdated

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="StorefrontAssertProductNameIsNotOnProductMainPageActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rename the action group according to the correct naming conventions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed this. Thank you!

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in High Priority Pull Requests Dashboard Dec 11, 2020
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Dec 13, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8562 has been created to process this Pull Request

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

1 similar comment
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Merge branch '2.4-develop-mainline' into ref-QuickSearch
a675e9f 
# Conflicts:
#	app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductTieredPriceTest.xml
#	app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductWithRegularPriceInStockNotVisibleIndividuallyTest.xml
#	app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductWithRegularPriceInStockVisibleInCatalogAndSearchTest.xml
#	app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductWithRegularPriceInStockVisibleInCatalogOnlyTest.xml
#	app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductWithRegularPriceInStockVisibleInSearchOnlyTest.xml
#	app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductWithRegularPriceOutOfStockTest.xml
@engcom-Foxtrot
magento#31251: [MFTF] Refactoring of Search actions on Storefront.
b162d05
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

2 similar comments
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

1 similar comment
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Dec 31, 2020
@gabrieldagama
Copy link
Contributor

@magento run all tests

@gabrieldagama
Copy link
Contributor

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Jan 23, 2021
@gabrieldagama
ENGCOM-8562: [MFTF] Refactoring of Search actions on Storefront #31240
4461567
@magento-engcom-team magento-engcom-team merged commit bff5a78 into magento:2.4-develop Jan 23, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 23, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: CatalogSearch Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Refactoring of Search actions on Storefront
7 participants
@AnnaAPak @sidolov @engcom-Delta @engcom-Foxtrot @magento-engcom-team @gabrieldagama @rogyar