Refactor of 'Around' plugins #31360

lbajsarowicz · 2020-12-18T23:38:52Z

Description (*)

Several minor updates to around plugins in Magento, introduced during the review of the existing plugins (looking for invalid uses for around plugins)

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Refactor of 'Around' plugins #31443: Refactor of 'Around' plugins

m2-assistant · 2020-12-18T23:38:54Z

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

orlangur

Nice @lbajsarowicz !

Broken functional tests do not seem to be related to changes introduced in PR.

magento-engcom-team · 2020-12-20T01:55:37Z

Hi @orlangur, thank you for the review.
ENGCOM-8555 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

sidolov · 2020-12-23T16:55:30Z

@magento create issue

ihor-sviziev · 2021-01-29T13:18:03Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

mrtuvn · 2021-04-16T01:22:27Z

@magento run Functional Tests B2B, Functional Tests CE

mrtuvn · 2021-06-05T04:24:51Z

@magento run Functional Tests CE, Functional Tests B2B

magento-automated-testing · 2021-06-05T04:24:58Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-02-10T08:56:49Z

@magento run all tests

magento-automated-testing · 2023-02-10T08:56:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-02-10T10:37:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-02-13T11:02:48Z

@lbajsarowicz @orlangur
Thanks for the collaboration & contribution!

✔️ QA Passed
Refactor of 'Around' plugins

Manual Scenario Steps

Verified all minor changes and also tested using create configurable product from admin .

After: ✔️
Configurable product created from backend.

There are some build failures hence moving to Extended Testing

engcom-Echo · 2023-02-13T11:17:17Z

@magento run all tests

magento-automated-testing · 2023-02-13T11:17:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-02-13T15:04:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-02-14T04:18:52Z

Failing Functional Tests B2B are different on same commit. On last two run different test are failing.

Run1

Run2

Hence Moving to Merge In Progress

lbajsarowicz added 5 commits December 19, 2020 00:21

Refactor: PriceBackend plugin

0ad8dc2

Refactor: SecurityInfo plugin

3ee2bd5

Refactor: GuestAuthorization plugin

b979e0a

Refactor: PriceBackend plugin

268d2bb

Refactor: Widget Layout ResourceModel plugin

78309c6

orlangur approved these changes Dec 20, 2020

View reviewed changes

m2-community-project bot assigned orlangur Dec 20, 2020

m2-community-project bot added the Progress: ready for testing label Dec 20, 2020

orlangur added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 20, 2020

orlangur removed the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 22, 2020

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 23, 2020

m2-assistant bot mentioned this pull request Dec 23, 2020

[Issue] Refactor of 'Around' plugins #31443

Closed

4 tasks

ihor-sviziev added the Cleanup label Apr 16, 2021

sinhaparul added the Project: Community Picked PRs upvoted by the community label Feb 1, 2023

engcom-Lima added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Feb 9, 2023

Merge branch '2.4-develop' into refactor/around-plugins

6a7d8d4

engcom-Echo self-assigned this Feb 10, 2023

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Feb 10, 2023

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Feb 13, 2023

Fixed static tests failures

8b57109

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Feb 14, 2023

magento-devops-reposync-svc merged commit e22aa46 into magento:2.4-develop Feb 23, 2023

lbajsarowicz deleted the refactor/around-plugins branch February 26, 2024 11:34

Refactor of 'Around' plugins #31360

Refactor of 'Around' plugins #31360

Uh oh!

Conversation

lbajsarowicz commented Dec 18, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Dec 18, 2020

Uh oh!

orlangur left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Dec 20, 2020

Uh oh!

sidolov commented Dec 23, 2020

Uh oh!

ihor-sviziev commented Jan 29, 2021

Uh oh!

mrtuvn commented Apr 16, 2021

Uh oh!

mrtuvn commented Jun 5, 2021

Uh oh!

magento-automated-testing bot commented Jun 5, 2021

Uh oh!

engcom-Echo commented Feb 10, 2023

Uh oh!

magento-automated-testing bot commented Feb 10, 2023

Uh oh!

magento-automated-testing bot commented Feb 10, 2023

Uh oh!

engcom-Echo commented Feb 13, 2023

Uh oh!

engcom-Echo commented Feb 13, 2023

Uh oh!

magento-automated-testing bot commented Feb 13, 2023

Uh oh!

magento-automated-testing bot commented Feb 13, 2023

Uh oh!

engcom-Echo commented Feb 14, 2023

Uh oh!

Uh oh!

lbajsarowicz commented Dec 18, 2020 •

edited by m2-assistant bot

Loading