MC-39718: Process Manager always exits successfully #31368

engcom-Golf · 2020-12-21T08:12:46Z

if the amount of functions(i.e. indexer dimensions) is lower than the MAGE_INDEXER_THREADS_COUNT env variable

Description (*)

Added logic to check if child process has exit code >0 then mark parent process as failed

Related Pull Requests

Fixed Issues (if relevant)

Fixes Process Manager always exits successfully if the amount of functions(i.e. indexer dimensions) is lower than the MAGE_INDEXER_THREADS_COUNT env variable #30964

Manual testing scenarios (*)

Configure a second website with store and store view
Generate a small profile for performance testing
Run fulltext_search reindex with parameter MAGE_INDEXER_THREADS_COUNT > {stores count}
While reindex is not finished disable elasticsearch in a separate terminal window

Expected result:

The message "reindex successfully finished" is not shown
Reindex is not marked as valid in admin

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-12-21T08:12:48Z

Hi @engcom-Golf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Golf · 2020-12-21T08:13:09Z

@magento run all tests

ihor-sviziev · 2020-12-21T09:35:20Z

app/code/Magento/Indexer/Model/ProcessManager.php

@@ -114,6 +114,9 @@ private function multiThreadsExecute($userFunctions)
        // phpcs:ignore Magento2.CodeAnalysis.EmptyBlock,Magento2.Functions.DiscouragedFunction


I believe this ignoring of empty block could be removed?

Suggested change

// phpcs:ignore Magento2.CodeAnalysis.EmptyBlock,Magento2.Functions.DiscouragedFunction

// phpcs:ignore Magento2.Functions.DiscouragedFunction

ihor-sviziev · 2020-12-21T09:39:46Z

app/code/Magento/Indexer/Test/Unit/Model/ProcessManagerTest.php

+    public function closureFunctionsProvider(): array
+    {
+        return [
+            'more_threads_than_functions' => [


Could you also add coverage for cases when it's mess threads than functions and when it's equal? Just to make sure it works fine as well

thanks for looking into it, will do

added variations

…functions(i.e. indexer dimensions) is lower than the MAGE_INDEXER_THREADS_COUNT env variable

engcom-Golf · 2020-12-21T10:27:08Z

@magento run all tests

ihor-sviziev · 2020-12-21T12:04:35Z

@magento run Functional Tests B2B

Looks good. Let's wait for test results

magento-engcom-team · 2020-12-21T16:37:08Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8567 has been created to process this Pull Request

engcom-Bravo · 2020-12-22T10:05:46Z

✔️ QA Passed

Manual testing scenario

Generate a small profile for performance testing bin/magento setup:performance:generate-fixtures setup/performance-toolkit/profiles/ce/small.xml
Run fulltext_search reindex with parameter MAGE_INDEXER_THREADS_COUNT > {stores count} MAGE_INDEXER_THREADS_COUNT=4 php bin/magento indexer:reindex catalogsearch_fulltext
While reindex is not finished, disable Elasticsearch in a separate terminal window sudo service elasticsearch stop

Before applying changes provided in the PR, the Process Manager exited successfully

After switching to the PR, the Process Manager exits with Fail in child process error

zakdma · 2020-12-26T09:36:50Z

@magento import code to https://github.com/magento-tsg/magento2ce

magento-engcom-team · 2020-12-26T09:38:56Z

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31368.

m2-assistant · 2020-12-26T17:06:55Z

Hi @engcom-Golf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Dec 21, 2020

magento-engcom-team added Component: Indexer Release Line: 2.4 labels Dec 21, 2020

m2-community-project bot added this to Pending Review in High Priority Pull Requests Dashboard Dec 21, 2020

m2-community-project bot added the Progress: pending review label Dec 21, 2020

ihor-sviziev self-assigned this Dec 21, 2020

m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Dec 21, 2020

m2-community-project bot added Progress: review and removed Progress: pending review labels Dec 21, 2020

ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Progress: pending review and removed Progress: review labels Dec 21, 2020

m2-community-project bot moved this from Review in Progress to Pending Review in High Priority Pull Requests Dashboard Dec 21, 2020

ihor-sviziev requested changes Dec 21, 2020

View reviewed changes

m2-community-project bot moved this from Pending Review to Changes Requested in High Priority Pull Requests Dashboard Dec 21, 2020

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Dec 21, 2020

ihor-sviziev requested changes Dec 21, 2020

View reviewed changes

m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Dec 21, 2020

m2-community-project bot added Progress: review and removed Progress: needs update labels Dec 21, 2020

ihor-sviziev added the Progress: needs update label Dec 21, 2020

m2-community-project bot moved this from Review in Progress to Changes Requested in High Priority Pull Requests Dashboard Dec 21, 2020

m2-community-project bot removed the Progress: review label Dec 21, 2020

MC-39718: Process Manager always exits successfully if the amount of …

e45a944

…functions(i.e. indexer dimensions) is lower than the MAGE_INDEXER_THREADS_COUNT env variable

engcom-Golf force-pushed the MC-39718 branch from 7896526 to e45a944 Compare December 21, 2020 10:26

m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Dec 21, 2020

m2-community-project bot added Progress: review and removed Progress: needs update labels Dec 21, 2020

engcom-Golf requested review from zakdma, engcom-Kilo and viktorpetryk December 21, 2020 11:33

engcom-Kilo approved these changes Dec 21, 2020

View reviewed changes

m2-community-project bot assigned engcom-Kilo Dec 21, 2020

m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Dec 21, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Dec 21, 2020

ihor-sviziev approved these changes Dec 21, 2020

View reviewed changes

engcom-Bravo self-assigned this Dec 22, 2020

engcom-Bravo moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Dec 22, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 22, 2020

engcom-Bravo moved this from Testing in Progress to Merge in Progress in High Priority Pull Requests Dashboard Dec 22, 2020

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Dec 22, 2020

magento-engcom-team merged commit 4b460ab into magento:2.4-develop Dec 26, 2020

gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Jan 6, 2021

magento-engcom-team removed this from Recently Merged in High Priority Pull Requests Dashboard Oct 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MC-39718: Process Manager always exits successfully #31368

MC-39718: Process Manager always exits successfully #31368

engcom-Golf commented Dec 21, 2020

m2-assistant bot commented Dec 21, 2020

engcom-Golf commented Dec 21, 2020

ihor-sviziev Dec 21, 2020

engcom-Golf Dec 21, 2020

ihor-sviziev Dec 21, 2020 •

edited

Loading

engcom-Golf Dec 21, 2020

engcom-Golf Dec 21, 2020

engcom-Golf commented Dec 21, 2020

ihor-sviziev commented Dec 21, 2020 •

edited

Loading

magento-engcom-team commented Dec 21, 2020

engcom-Bravo commented Dec 22, 2020

zakdma commented Dec 26, 2020

magento-engcom-team commented Dec 26, 2020

m2-assistant bot commented Dec 26, 2020

		@@ -114,6 +114,9 @@ private function multiThreadsExecute($userFunctions)
		// phpcs:ignore Magento2.CodeAnalysis.EmptyBlock,Magento2.Functions.DiscouragedFunction

	// phpcs:ignore Magento2.CodeAnalysis.EmptyBlock,Magento2.Functions.DiscouragedFunction
	// phpcs:ignore Magento2.Functions.DiscouragedFunction

MC-39718: Process Manager always exits successfully #31368

MC-39718: Process Manager always exits successfully #31368

Conversation

engcom-Golf commented Dec 21, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Expected result:

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Dec 21, 2020

engcom-Golf commented Dec 21, 2020

ihor-sviziev Dec 21, 2020

Choose a reason for hiding this comment

engcom-Golf Dec 21, 2020

Choose a reason for hiding this comment

ihor-sviziev Dec 21, 2020 • edited Loading

Choose a reason for hiding this comment

engcom-Golf Dec 21, 2020

Choose a reason for hiding this comment

engcom-Golf Dec 21, 2020

Choose a reason for hiding this comment

engcom-Golf commented Dec 21, 2020

ihor-sviziev commented Dec 21, 2020 • edited Loading

magento-engcom-team commented Dec 21, 2020

engcom-Bravo commented Dec 22, 2020

Manual testing scenario

zakdma commented Dec 26, 2020

magento-engcom-team commented Dec 26, 2020

m2-assistant bot commented Dec 26, 2020

ihor-sviziev Dec 21, 2020 •

edited

Loading

ihor-sviziev commented Dec 21, 2020 •

edited

Loading