Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Adding AdminClickCreateNewStatusButtonOnOrderStatusPageActionGroup #31604

Merged
merged 3 commits into from
Feb 5, 2021
Merged

[MFTF] Adding AdminClickCreateNewStatusButtonOnOrderStatusPageActionGroup #31604

merged 3 commits into from
Feb 5, 2021

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Jan 9, 2021 •
edited by m2-assistant bot
Loading

Description (*)

AdminClickCreateNewStatusButtonOnOrderStatusPageActionGroup has been added
Tests have been updated with AdminClickCreateNewStatusButtonOnOrderStatusPageActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] Adding AdminClickCreateNewStatusButtonOnOrderStatusPageActionGroup #31623: [MFTF] Adding AdminClickCreateNewStatusButtonOnOrderStatusPageActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2021

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 9, 2021
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 9, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B, Semantic Version Checker

1 similar comment
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B, Semantic Version Checker

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 11, 2021
@rogyar rogyar self-assigned this Jan 11, 2021
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Requests Dashboard Jan 11, 2021
@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Jan 11, 2021
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8616 has been created to process this Pull Request

@rogyar
Copy link
Contributor

rogyar commented Jan 11, 2021

Hi @AnnaAPak. Thank you for your work. It's a useful refactoring eventually. I would recommend focusing first of all on places where we may replace a couple of existing actions with a single action group.
Ideally, all the "clicks" should be replaced by action groups. However, it may unnecessarily increase the current codebase of tests.

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 12, 2021
@m2-community-project m2-community-project bot removed this from Ready for Testing in Pull Requests Dashboard Jan 12, 2021
@sidolov sidolov added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 12, 2021
@sidolov
Copy link
Contributor

sidolov commented Jan 12, 2021

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jan 12, 2021
Closed
@engcom-Alfa engcom-Alfa self-assigned this Jan 13, 2021
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Jan 13, 2021
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Jan 13, 2021
@engcom-Foxtrot engcom-Foxtrot self-assigned this Jan 13, 2021
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Jan 13, 2021
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Jan 13, 2021
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

2 similar comments
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Merge branch '2.4-develop-mainline' into add-AdminClickCreateNewStatu…
2f31728 
…sButtonOnOrderStatusPageActionGroup

# Conflicts:
#	app/code/Magento/Sales/Test/Mftf/Test/AdminCreateOrderStatusDuplicatingCodeTest.xml
#	app/code/Magento/Sales/Test/Mftf/Test/AdminCreateOrderStatusDuplicatingLabelTest.xml
#	app/code/Magento/Sales/Test/Mftf/Test/AdminCreateOrderStatusTest.xml
#	app/code/Magento/Sales/Test/Mftf/Test/AdminUnassignCustomOrderStatusTest.xml
#	app/code/Magento/Sales/Test/Mftf/Test/AssignCustomOrderStatusNotVisibleOnStorefrontTest.xml
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Jan 25, 2021
magento-engcom-team pushed a commit that referenced this pull request Feb 5, 2021
@gabrieldagama
ENGCOM-8616: [MFTF] Adding AdminClickCreateNewStatusButtonOnOrderStat…
8b5c060 
…usPageActionGroup #31604
@magento-engcom-team magento-engcom-team merged commit b23d6d7 into magento:2.4-develop Feb 5, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 5, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Type: Test Coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Adding AdminClickCreateNewStatusButtonOnOrderStatusPageActionGroup
7 participants
@AnnaAPak @magento-engcom-team @rogyar @sidolov @engcom-Alfa @engcom-Foxtrot @gabrieldagama