[MFTF] Removing the Sales MFTF dependency by Paypal module #31794

eduard13 · 2021-01-21T13:10:22Z

Description (*)

The aim of this PR is to get rid of the wrong dependency of Sales module on Paypal module. This dependency leads to broken Sales MFTF tests, in case we decide to remove the Magento_Paypal module.

Tests that are failing:

AdminSalesTransactionsNavigateMenuTest
AdminSalesCreditMemosNavigateMenuTest
AdminSalesInvoicesNavigateMenuTest
AdminSalesOrdersNavigateMenuTest
AdminSalesShipmentsNavigateMenuTest

This is happened because Magento_Sales MFTF tests are trying to reference for a Menu Item that was declared in Magento_Paypal module.

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

Remove the Paypal module
Run any test mentioned above

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-01-21T13:10:25Z

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

eduard13 · 2021-01-21T13:13:38Z

@magento run all tests

gabrieldagama · 2021-01-21T17:52:35Z

@magento run Static Tests

eduard13 · 2021-01-22T13:08:20Z

@magento run WebAPI Tests, Functional Tests CE, Functional Tests B2B

@gabrieldagama as for the failed SVC, I think we should be fine, as we're not completely removing that Entity, just moving to another place. What do you think?

gabrieldagama · 2021-01-22T15:14:47Z

Hi @eduard13, thanks for contributing! Yes, I agree, that shouldn't be a problem, it is a false-positive and it should be a quick approval process.

eduard13 · 2021-01-23T07:59:55Z

@magento run Functional Tests CE, Functional Tests B2B

rogyar

Good job!

engcom-Alfa · 2021-01-25T07:10:22Z

QA not applicable

eduard13 · 2021-11-24T19:17:15Z

@magento run all tests

Hi @sidolov, is there any update on the approval of the internal ticket?

Thank you.

magento-automated-testing · 2021-11-24T19:17:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa · 2022-04-11T12:35:43Z

@magento run Functional Tests B2B, Functional Tests EE

magento-automated-testing · 2022-04-11T12:35:51Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa · 2022-04-11T14:09:22Z

We have the approval for the SVC failure from our internal approval ticket comment, considering it for further process.

engcom-Alfa · 2022-04-12T12:32:54Z

✔️ QA Passed

This PR is relevant to the MFTF test code factoring as per the description and as looked into the files changed.
Along with SVC failure approvals as mentioned above, the auto-test jobs are also successfully running with this PR, moving to Merge In Progress.
Thanks for the contribution and collaboration all.

ishakhsuvarov · 2022-06-22T17:20:26Z

@magento run all tests

magento-automated-testing · 2022-06-22T17:20:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ishakhsuvarov · 2022-06-27T15:02:12Z

@magento run all tests

magento-automated-testing · 2022-06-27T15:02:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ishakhsuvarov · 2022-06-28T16:57:40Z

@magento run Functional Tests B2B, WebAPI Tests

magento-automated-testing · 2022-06-28T16:57:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ishakhsuvarov · 2022-06-28T22:29:37Z

@magento run Functional Tests B2B

magento-automated-testing · 2022-06-28T22:29:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2022-08-23T12:29:41Z

@magento give me test instance

magento-deployment-service · 2022-08-23T12:29:45Z

Hi @eduard13. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2022-08-23T12:33:55Z

Hi @eduard13, here is your Magento Instance: https://edcb0b2d20683e13de1902285a237a74.instances.magento-community.engineering
Admin access: https://edcb0b2d20683e13de1902285a237a74.instances.magento-community.engineering/admin_2769
Login: 226849ac
Password: c8e4c85dc760

Removing the Sales MFTF dependency by Paypal module

398e9d8

magento-engcom-team added Component: Paypal Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 21, 2021

gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 21, 2021

m2-community-project bot added the Progress: pending review label Jan 21, 2021

rogyar self-assigned this Jan 23, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 23, 2021

rogyar approved these changes Jan 23, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Jan 23, 2021

engcom-Alfa self-assigned this Jan 25, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Jan 25, 2021

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Jan 25, 2021

engcom-Foxtrot self-assigned this Jan 25, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: extended testing labels Jan 25, 2021

Merge branch '2.4-develop' into mftf-improvement-1

cb45023

m2-community-project bot added Progress: testing in progress and removed Progress: pending approval labels Apr 11, 2022

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Apr 12, 2022

Merge branch '2.4-develop' into mftf-improvement-1

a287f10

Merge branch '2.4-develop' into mftf-improvement-1

7d0bcc1

m2-community-project bot added Progress: to approve Progress: accept and removed Progress: accept Progress: to approve labels Oct 19, 2022

magento-devops-reposync-svc merged commit f866ee7 into magento:2.4-develop Oct 28, 2022

eduard13 deleted the mftf-improvement-1 branch October 29, 2022 06:25

[MFTF] Removing the Sales MFTF dependency by Paypal module #31794

[MFTF] Removing the Sales MFTF dependency by Paypal module #31794

Uh oh!

Conversation

eduard13 commented Jan 21, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jan 21, 2021

Uh oh!

eduard13 commented Jan 21, 2021

Uh oh!

gabrieldagama commented Jan 21, 2021

Uh oh!

eduard13 commented Jan 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabrieldagama commented Jan 22, 2021

Uh oh!

eduard13 commented Jan 23, 2021

Uh oh!

rogyar left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Alfa commented Jan 25, 2021

Uh oh!

eduard13 commented Nov 24, 2021

Uh oh!

magento-automated-testing bot commented Nov 24, 2021

Uh oh!

engcom-Alfa commented Apr 11, 2022

Uh oh!

magento-automated-testing bot commented Apr 11, 2022

Uh oh!

engcom-Alfa commented Apr 11, 2022

Uh oh!

engcom-Alfa commented Apr 12, 2022

Uh oh!

ishakhsuvarov commented Jun 22, 2022

Uh oh!

magento-automated-testing bot commented Jun 22, 2022

Uh oh!

ishakhsuvarov commented Jun 27, 2022

Uh oh!

magento-automated-testing bot commented Jun 27, 2022

Uh oh!

ishakhsuvarov commented Jun 28, 2022

Uh oh!

magento-automated-testing bot commented Jun 28, 2022

Uh oh!

ishakhsuvarov commented Jun 28, 2022

Uh oh!

magento-automated-testing bot commented Jun 28, 2022

Uh oh!

eduard13 commented Aug 23, 2022

Uh oh!

magento-deployment-service bot commented Aug 23, 2022

Uh oh!

magento-deployment-service bot commented Aug 23, 2022

Uh oh!

Uh oh!

eduard13 commented Jan 22, 2021 •

edited

Loading