Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress possible ASP tags usage warning #31913

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Suppress possible ASP tags usage warning #31913

merged 2 commits into from
Feb 18, 2021

Conversation

sergeynezbritskiy
Copy link
Contributor

Description (*)

Suppress possible ASP tags usage warning

Fixed Issues (if relevant)

  1. Fixes Update magento2 codebase to be compatible with PHP 8 #31081

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 31, 2021

Hi @sergeynezbritskiy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 31, 2021
@m2-community-project m2-community-project bot added this to Pending Review in Platform Health PRs Jan 31, 2021
@sergeynezbritskiy sergeynezbritskiy mentioned this pull request Jan 31, 2021
Closed
@ihor-sviziev ihor-sviziev self-assigned this Feb 1, 2021
@m2-community-project m2-community-project bot removed this from Pending Review in Platform Health PRs Feb 1, 2021
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 1, 2021 •
edited
Loading

Hi @sergeynezbritskiy,
Does it seem like this PR isn't fixing #31081, but cleans up the codebase to have more clear reports?

Could you create a separate issue for that and link this PR to it?

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@sergeynezbritskiy
Copy link
Contributor Author

Hi @ihor-sviziev
Yes, you're absolutely right. The purpose of this PR is just to reduce noise in the report. And there will be few more PRs within #31081

ihor-sviziev
ihor-sviziev requested changes Feb 2, 2021
View reviewed changes
app/code/Magento/Backend/view/adminhtml/templates/system/search.phtml Outdated Show resolved Hide resolved
app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/summary.phtml Show resolved Hide resolved
app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/file.phtml Outdated Show resolved Hide resolved
app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/links.phtml Outdated Show resolved Hide resolved
app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/samples.phtml Outdated Show resolved Hide resolved
app/code/Magento/Shipping/view/adminhtml/templates/order/tracking.phtml Outdated Show resolved Hide resolved
app/code/Magento/Weee/view/adminhtml/templates/renderer/tax.phtml Outdated Show resolved Hide resolved
@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in High Priority Pull Requests Dashboard Feb 2, 2021
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: review Project: PHP8 and removed Progress: needs update labels Feb 2, 2021
@m2-community-project m2-community-project bot added this to Review in Progress in Platform Health PRs Feb 2, 2021
@m2-community-project m2-community-project bot removed this from Changes Requested in High Priority Pull Requests Dashboard Feb 2, 2021
@ihor-sviziev ihor-sviziev added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Feb 2, 2021
@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Platform Health PRs Feb 2, 2021
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Platform Health PRs Feb 2, 2021
@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Platform Health PRs Feb 2, 2021
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Platform Health PRs Feb 2, 2021
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Database Compare, Functional Tests B2B, Functional Tests EE

@ihor-sviziev
Copy link
Contributor

Hi @sergeynezbritskiy,
Could you re-target this PR to the php8-develop branch if it is related to it?

@hostep
Copy link
Contributor

hostep commented Feb 3, 2021

This may be a stupid question, but could somebody explain what this <%- ... %> sytnax is? It's not knockout.js as far as I know, so what is this? And shouldn't we clean that up instead of ignoring it in coding standards?

@sergeynezbritskiy
Copy link
Contributor Author

This may be a stupid question, but could somebody explain what this <%- ... %> sytnax is? It's not knockout.js as far as I know, so what is this? And shouldn't we clean that up instead of ignoring it in coding standards?

Hi @hostep , looks like it is underscorejs syntax https://underscorejs.org/#template

@ihor-sviziev
Copy link
Contributor

@magento run Database Compare, Functional Tests B2B, Functional Tests EE

@gabrieldagama
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

@sergeynezbritskiy sergeynezbritskiy changed the base branch from 2.5-develop to php8-develop February 6, 2021 19:38
@sergeynezbritskiy
Copy link
Contributor Author

Hi @sergeynezbritskiy,
Could you re-target this PR to the php8-develop branch if it is related to it?

Hi @ihor-sviziev, re-targeted to php8-develop

@sergeynezbritskiy
Copy link
Contributor Author

@magento run all tests

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Platform Health PRs Feb 7, 2021
@mmansoor-magento mmansoor-magento merged commit cb0635a into magento:php8-develop Feb 18, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2021

Hi @sergeynezbritskiy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sivaschenko sivaschenko moved this from Ready for Testing to Recently Merged in Platform Health PRs Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@sivaschenko sivaschenko

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: PHP8 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
No open projects
Platform Health PRs
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sergeynezbritskiy @ihor-sviziev @hostep @gabrieldagama @sivaschenko @mmansoor-magento