Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed CliCacheFlushActionGroup usage for Customer module #32078

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Removed CliCacheFlushActionGroup usage for Customer module #32078

merged 1 commit into from
Mar 7, 2021

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Feb 10, 2021 •
edited by m2-assistant bot
Loading

Description

Removed CliCacheFlushActionGroup usage (or changed value) for Checkout, CurrencySymbol and Customer modules.

Resolved issues:

  1. resolves [Issue] Removed CliCacheFlushActionGroup usage for Customer module #32079: Removed CliCacheFlushActionGroup usage for Customer module

@m2-assistant
Copy link

m2-assistant bot commented Feb 10, 2021

Hi @sergiy-v. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergiy-v
Copy link
Contributor Author

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Feb 10, 2021
Closed
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Semantic Version Checker

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Feb 10, 2021
@coderimus coderimus self-assigned this Feb 10, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Feb 10, 2021
@sergiy-v
Copy link
Contributor Author

Will check failed tests.

@sergiy-v sergiy-v changed the title Removed CliCacheFlushActionGroup usage for Customer module [WIP] Removed CliCacheFlushActionGroup usage for Customer module Feb 10, 2021
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

7 similar comments
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run WebAPI Tests, Unit Tests, Static Tests, Sample Data Tests EE, Sample Data Tests CE, Sample Data Tests B2B, Magento Health Index, Integration Tests, Database Compare

@magento-engcom-team
Copy link
Contributor

Hi @coderimus, thank you for the review.
ENGCOM-8788 has been created to process this Pull Request
✳️ @coderimus, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@coderimus coderimus added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Feb 22, 2021
@m2-community-project m2-community-project bot removed this from Ready for Testing in Pull Requests Dashboard Feb 22, 2021
@engcom-Bravo engcom-Bravo self-assigned this Feb 22, 2021
@engcom-Bravo
Copy link
Contributor

Manual QA not applicable. Moving this PR to the Extended Testing column

@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Feb 22, 2021
@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Feb 22, 2021
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Testing in Progress in High Priority Pull Requests Dashboard Feb 22, 2021
@m2-community-project m2-community-project bot moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Feb 22, 2021
@engcom-Hotel engcom-Hotel self-assigned this Feb 22, 2021
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Feb 22, 2021
@engcom-Hotel engcom-Hotel moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Feb 22, 2021
magento-engcom-team pushed a commit that referenced this pull request Mar 7, 2021
@gabrieldagama
ENGCOM-8788: Removed CliCacheFlushActionGroup usage for Customer module
6aa5a70 
#32078
@magento-engcom-team magento-engcom-team merged commit 8e25eb8 into magento:2.4-develop Mar 7, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 7, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderimus coderimus coderimus approved these changes

Assignees

@coderimus coderimus

@engcom-Bravo engcom-Bravo

@engcom-Hotel engcom-Hotel

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Checkout Component: CurrencySymbol Component: Customer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Type: Test Coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed CliCacheFlushActionGroup usage for Customer module
6 participants
@sergiy-v @magento-engcom-team @engcom-Bravo @coderimus @gabrieldagama @engcom-Hotel