Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle upsell missing limit bug #32147

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

kodubovik
Copy link
Contributor

Description (*)

An observer Magento\Bundle\Observer\AppendUpsellProductsObserver does not honour upsell limit configurations. That causes an issue with an infinite number of products added to the upsell collection and potentially leads to performance issues and bad user experience.
This fix updates "catalog_product_upsell" event dispatching with the config value set in the XML (app/code/Magento/Bundle/view/frontend/layout/catalog_product_view_type_simple.xml). It also includes some improvements to Unit Tests.

Fixed Issues (if relevant)

  1. Fixes Bundle products limit in upsell collection on product detail page #31840

Manual testing scenarios (*)

  1. Create a simple product, to be used as a child in several bundle products
  2. Create several bundle products and include a simple product created in the first step into all bundles. The number of bundles should be greater than four as the default number of products configured to be displayed in the upsell block is four.
  3. Flush Magento cache.
  4. Visit the simple product details page.
    • Actual result: all bundle products are displayed in the upsell block
    • Expected result:: only four bundle products should be displayed in the upsell block.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 12, 2021

Hi @kodubovik. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@kodubovik
Copy link
Contributor Author

@magento run all tests

@kodubovik
Copy link
Contributor Author

@magento run all tests

@kodubovik
Copy link
Contributor Author

@magento run WebAPI Tests, Functional Tests EE

@gabrieldagama gabrieldagama added the Priority: P3 May be fixed according to the position in the backlog. label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pull Requests Dashboard
  
Pending Review
Development

Successfully merging this pull request may close these issues.

Bundle products limit in upsell collection on product detail page
3 participants