New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bundle upsell missing limit bug #32147
base: 2.4-develop
Are you sure you want to change the base?
Fix bundle upsell missing limit bug #32147
Conversation
Hi @kodubovik. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run all tests |
@magento run WebAPI Tests, Functional Tests EE |
Description (*)
An observer Magento\Bundle\Observer\AppendUpsellProductsObserver does not honour upsell limit configurations. That causes an issue with an infinite number of products added to the upsell collection and potentially leads to performance issues and bad user experience.
This fix updates "catalog_product_upsell" event dispatching with the config value set in the XML (app/code/Magento/Bundle/view/frontend/layout/catalog_product_view_type_simple.xml). It also includes some improvements to Unit Tests.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)